Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 registerPlugin events triggered #70

Open
GildasMorel opened this issue Aug 4, 2020 · 2 comments
Open

4 registerPlugin events triggered #70

GildasMorel opened this issue Aug 4, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GildasMorel
Copy link
Collaborator

GildasMorel commented Aug 4, 2020

In talk-control-slave, in :

this.eventBusSlave.on(MASTER_SLAVE_CHANNEL, 'registerPlugin', ({ pluginName }) => {

Add :

if (pluginName === 'touchPointerInput') {
    console.log('slave => registerPlugin', pluginName, this.shadowRoot);
}

For layout stage view, there are 4 of thoses events triggered, but it should be only 2 : reveal engine talk control slave and slide-view talk control slave.

Why ?

@GildasMorel GildasMorel added the question Further information is requested label Aug 4, 2020
@GildasMorel GildasMorel added this to the One day milestone Aug 4, 2020
@GildasMorel GildasMorel added the bug Something isn't working label Aug 4, 2020
@GildasMorel
Copy link
Collaborator Author

This bug causes the zooming behavior with dlbclick to not work on branch feat/61-handle-input-generators-as-plugins

@GildasMorel GildasMorel removed the question Further information is requested label Aug 10, 2020
@GildasMorel
Copy link
Collaborator Author

GildasMorel commented Aug 10, 2020

Found!
We must not call super.init() in components slaves (like slide-view-slave.js)

GildasMorel added a commit that referenced this issue Aug 10, 2020
…rPlugin-events-triggered

Fix: #70 - Multiple registerPlugin events triggered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants