Refactor Keybindings and Set Defaults #500
danpastori
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
👉 Describe the problem
Allow for default keybindings to be set to control the audio player from the keyboard. It's a pain to set this everytime when 90% of the time the same button is going to perform the same task.
👥 Problem evidence & reach
Anyone wanting to control the audio player from the keyboard
🥰 Describe the "impact" on users?
You won't have to figure out basic key binding support, but maintain the ability to set any function to any key.
🏆 How to solve this problem
Step 1: Refactor the
bindings
config key to bekey_bindings
This will be a breaking change, but makes more sense. Documentation will be provided.
Step 2: Allow for the following configurations for keybindings:
Binding from key id to Amplitude method
Binding from key id to callback method
Binding from key id to custom method defined elsewhere
Default keybindings
💯 How do we validate the problem is solved?
Developers will be able to provide complete custom control from their keyboard to their audio player defined through the
key_bindings
config key. They will be able to map to an Amplitude method, callback method, custom method, or set just the defaults which will be defined in the documentation.Beta Was this translation helpful? Give feedback.
All reactions