Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cosmith/loki-cordova-fs-adapter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: servebox/loki-cordova-fs-adapter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 15, 2017

  1. Passes _getFile errors to callback

    @benitoDeLaCasita
    benitoDeLaCasita authored and Benoit Anselme committed Mar 15, 2017
    Copy the full SHA
    3ad62c5 View commit details
Showing with 5 additions and 3 deletions.
  1. +2 −1 bin/loki-cordova-fs-adapter.js
  2. +3 −2 src/loki-cordova-fs-adapter.es6
3 changes: 2 additions & 1 deletion bin/loki-cordova-fs-adapter.js
View file
Original file line number Diff line number Diff line change
@@ -112,7 +112,8 @@ var LokiCordovaFSAdapter = (function () {
var fileName = _this.options.prefix + "__" + name;
dir.getFile(fileName, { create: true }, handleSuccess, handleError);
}, function (err) {
throw new LokiCordovaFSAdapterError("Unable to resolve local file system URL" + JSON.stringify(err));
console.error(TAG, "error getting file", err);
handleError(new LokiCordovaFSAdapterError("Unable to resolve local file system URL" + JSON.stringify(err)));
});
}
},
5 changes: 3 additions & 2 deletions src/loki-cordova-fs-adapter.es6
View file
Original file line number Diff line number Diff line change
@@ -104,9 +104,10 @@ class LokiCordovaFSAdapter {
dir.getFile(fileName, {create: true}, handleSuccess, handleError);
},
(err) => {
throw new LokiCordovaFSAdapterError(
console.error(TAG, "error getting file", err);
handleError(new LokiCordovaFSAdapterError(
"Unable to resolve local file system URL" + JSON.stringify(err)
);
));
}
);
}