Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Run CI on default branch #300

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

rvem
Copy link
Member

@rvem rvem commented Sep 2, 2024

Description

Problem: Currently CI checks aren't run on the default branch.

Solution: Run CI pipeline with checks on 'master' too.

Related issue(s)

Fixes #

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the version number in package.yaml.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • (After merging) I edited the auto-release.
    • Change the tag and title using the format vX.Y.Z.
    • Write a summary of all user-facing changes.
    • Deselect the "This is a pre-release" checkbox at the bottom.
  • (After merging) I updated xrefcheck-action.
  • (After merging) I uploaded the package to hackage.

Problem: Currently CI checks aren't run on the default branch.

Solution: Run CI pipeline with checks on 'master' too.
@rvem rvem requested a review from gromakovsky September 2, 2024 10:33
@serokell-bot
Copy link
Contributor

1 Warning
⚠️ Bad issue ID in branch name.
Valid format for issue IDs: #123 or chore.

Generated by 🚫 Danger

@rvem rvem merged commit ec098b5 into master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants