[VSC-6] Add benchmarking setup #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krendelhoff2
force-pushed
the
krendelhoff/vsc-6-benchmark-server
branch
2 times, most recently
from
4b2dae9 to
1c7fb9e
Compare
krendelhoff2
force-pushed
the
krendelhoff/vsc-6-benchmark-server
branch
from
1c7fb9e to
affb7f6
Compare
GoPavel
reviewed
Feb 25, 2025
Comment on lines
+443
to
+446
| const key = | ||
| keys.length === 1 | ||
| ? keys[0] | ||
| : 'local'; |
There was a problem hiding this comment.
This is auto-formating I guess. Is it a standard one? Do you think that Dfinity developers will have the same setting?
GoPavel
reviewed
Feb 25, 2025
| loadingPackages = false; | ||
| notifyWorkspace(); // Update virtual file system | ||
| notifyDfxChange(); // Reload dfx.json | ||
| connection.sendNotification('custom/initialized', {}); |
There was a problem hiding this comment.
I see why this hack is needed, but please add some comments on why it's needed. Someone who is not in the context of the benchmarks could be surprised by this.
| params: object, | ||
| times: number, | ||
| ): Promise<number[]> { | ||
| assert(times > 1, 'times must be greater than 0'); |
There was a problem hiding this comment.
I think it should be times > 0 here and in other places accepting times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to run:
<path_to_root>should have some big motoko project e.g. game-launcher, power-equalizer which could be installed via: