Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING guide #95

Closed
Neirda24 opened this issue Jul 9, 2024 · 3 comments · Fixed by #129
Closed

Add a CONTRIBUTING guide #95

Neirda24 opened this issue Jul 9, 2024 · 3 comments · Fixed by #129
Milestone

Comments

@Neirda24
Copy link
Contributor

Neirda24 commented Jul 9, 2024

No description provided.

@smnandre
Copy link
Contributor

Contributing to GotenbergBundle

Thank you for your interest in contributing to GotenbergBundle! Your support helps make this project better for everyone.

How to Contribute

Report Issues

Found a bug or have a feature request? Open an issue to let us know.

Submit Pull Requests

  • Fork the repository.
  • Create a new branch for your changes.
  • Ensure your code follows the existing style and includes tests if applicable.
  • Submit a pull request with a clear description of your changes.

Installation

To set up the project locally for development:

Clone the Repository

git clone https://github.com/sensiolabs/GotenbergBundle.git
cd GotenbergBundle

Install Dependencies

composer install

Configure Environment

Copy the example environment file and adjust configurations as needed.

cp .env.example .env

Update .env with your local settings.

Testing

Ensure your changes work as expected by running the test suite:

Run Tests

./vendor/bin/phpunit

Run Tests with Coverage (optional)

./vendor/bin/phpunit --coverage-text

Quality Assurance

Maintain high code quality by following these steps before submitting a pull request:

Code Linting

./vendor/bin/phpcs

Ensure your code adheres to the coding standards.

Static Analysis

./vendor/bin/phpstan analyse

Detect potential issues in your code.

Fix Issues

Address any warnings or errors reported by the tools above.

Guidelines

  • Code Quality: Write clean and maintainable code.
  • Testing: Include tests for new features and bug fixes.
  • Documentation: Update documentation as needed to reflect your changes.

Code of Conduct

Please adhere to our Code of Conduct to ensure a welcoming environment for all contributors.

Thank you for contributing to GotenbergBundle!

@smnandre
Copy link
Contributor

Let's open a PR on that base and iterate, wdyt ?

@Jean-Beru
Copy link
Contributor

👍

Don't forget to add the php ./doc/generate.php script.

It updates builders documentation from the class's source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants