Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location: OSM geometry types, and non-OSM geometry - two related issues #769

Open
tlongers opened this issue Jun 18, 2021 · 0 comments
Open

Comments

@tlongers
Copy link
Member

I spotted two Locations issues that we may have missed in the locations refactor:

  • in the search results table for units, the outlinks to OSM in the "site" column are all nodes. This is incorrect, as sites may also be other geotypes (relations, ways) now. The url in the sites column should not assume the geotype is a node.
  • non-OSM objects may be present in the data now. They are flagged as such in location:origin ("osm" for OSM, "sfm" or other values for non-OSM). We will have to look at how we represent these non-OSM shapes across WWIC. For example, in the sites or areas of operation block in units records, non-OSM objects would not need an outlink to OSM.
    Let's discuss. We can split this out into separate issues as we find a forwad path.
@tlongers tlongers changed the title Location geometry - two issues Location: OSM geometry types, and non-OSM geometry - two related issues Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant