Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resource id in more_attributes with resource code #145

Closed
joe4dev opened this issue Sep 23, 2016 · 2 comments
Closed

Replace resource id in more_attributes with resource code #145

joe4dev opened this issue Sep 23, 2016 · 2 comments
Assignees
Labels

Comments

@joe4dev
Copy link
Collaborator

joe4dev commented Sep 23, 2016

DeployementRecommendation#ingredient_resource_mapping uses lookup_resource_ids to translate the resource codes into resource id's at the moment a recommendation is generated.
This behavior invalidates all recommendations whenever the provider updaters re-create all resources and likely change resource id's !!!

For this purpose, resource codes were introduced. However, they need to be resolved whenever more_attributes is accessed / used to prevent this behavior.

@joe4dev joe4dev added the bug label Sep 23, 2016
@joe4dev joe4dev self-assigned this Sep 23, 2016
@joe4dev
Copy link
Collaborator Author

joe4dev commented Oct 10, 2016

Consistently using #find_or_create_by in all provider updaters alleviates this issue but doesn't solve the maintenance problem for legacy instances. For further discussion see: #160 (comment)

@inz
Copy link
Collaborator

inz commented Oct 10, 2016

👍 agreed

On Monday, October 10, 2016, Joel Scheuner [email protected] wrote:

Consistently using #find_or_create_by alleviates this issue but doesn't
solve the maintenance problem for legacy instances. For further discussion
see: #160 (comment)
#160 (comment)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#145 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAXncTc5iM7rh7hHckIbbnxr6k3Y7etks5qyhh4gaJpZM4KEfXV
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants