Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon recommendations are generated if no provider data is available #123

Closed
joe4dev opened this issue Aug 19, 2016 · 4 comments
Closed

Comments

@joe4dev
Copy link
Collaborator

joe4dev commented Aug 19, 2016

If recommendations are requested for providers that have no data available, a recommendation for Amazon is generated instead without further warnings.

One might want to indicate that no provider data is available instead of silently switching to another provider.

@inz
Copy link
Collaborator

inz commented Oct 11, 2016

Is this still the case? Do we have providers without data?

@joe4dev
Copy link
Collaborator Author

joe4dev commented Oct 11, 2016

Basically no. All providers do have data.
This was more intended as an additional check that in case sth goes wrong with the updaters (e.g., might be broken), the recommendations do not just fail silently.

@inz
Copy link
Collaborator

inz commented Oct 11, 2016

Ok got it, I agree.

@inz
Copy link
Collaborator

inz commented Mar 2, 2017

Issue closed due to inactivity (as part of repository cleanup). You can reopen this issue once work on it starts.

@inz inz closed this as completed Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants