docker: update LLVM debian repo for Ubuntu Orcular migration #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating from Ubuntu Matis to Orcular in afea41b, the LLVM debian package repository configuration wasn't updated accordingly. This caused Docker builds to fail. This commit updates the repository configuration to match the new Ubuntu Orcular base image. Fixes scylladb#2656 Signed-off-by: Kefu Chai <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Add GitHub workflow to detect regressions in docker/dev/Dockerfile by: - Building a container image on Dockerfile changes in PRs - Running test suite against the built image in dev mode - Using clang++ compiler with C++23 standard This helps catch build issues and incompatibilities early in the development process. Refs scylladb#2656 Signed-off-by: Kefu Chai <[email protected]>
|
please note, the newly added workflow only tests the change by building the image, it does not test by building seastar and running the test executables. will create a follow-up change to integrate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from Ubuntu Matis to Orcular in afea41b, the LLVM debian package repository configuration wasn't updated accordingly. This caused Docker builds to fail.
This commit updates the repository configuration to match the new Ubuntu Orcular base image.
Fixes #2656