Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After adding pen extension, rendering results are different #5673

Closed
Ryuurock opened this issue Apr 23, 2020 · 9 comments
Closed

After adding pen extension, rendering results are different #5673

Ryuurock opened this issue Apr 23, 2020 · 9 comments
Assignees
Milestone

Comments

@Ryuurock
Copy link

Ryuurock commented Apr 23, 2020

Expected Behavior

Adding pen extensions should not affect rendering results

Actual Behavior

Rendering results are affected after adding pen extension

Steps to Reproduce

  1. Load the provided sb3 file
  2. Click the green flag
  3. The face on the left will move up
  4. Add pen extension
  5. Reload the provided sb3 file,Click the green flag
  6. The face on the left will not move up

Operating System and Browser

_e.g. Mac OS 10.15.6 Chrome 80.0.3987.163

jump.zip
Please modify the file suffix to .sb3

Below is the animation I recorded
👇before load pen extension
Apr-23-2020 11-38-09

👇after load pen extension
Apr-23-2020 11-37-06

@Ryuurock
Copy link
Author

After investigation, it is found that it may be the problem caused here
scratch-vm/src/extensions/scratch3_pen/index.js

@BryceLTaylor
Copy link
Contributor

@Ryuurock I'm unable to reproduce this issue with that project. Are there more steps you take while adding the pen extension, such as adding any blocks to the project? Can you cause this issue to happen on a simpler project?

@Ryuurock
Copy link
Author

@BryceLTaylor Ok,I made some fixes

  1. Load the provided sb3 file, Click the green flag
  2. Check the stage, The face on the left will move up

Then reload scratch.

  1. First, add pen extension
  2. Load the provided sb3 file,Click the green flag
  3. The face on the left will not move up

@BryceLTaylor
Copy link
Contributor

Okay, so to see it you have to load it by doing File>Load from your computer, not reloading the page. It also seems to only happen with the pen extension (that I've tested so far.). It did not happen with the Music or the Makey Makey extension.

@Ryuurock Can you make a simplified version of the project that has only the minimum number of sprites and scripts to see this issue? I'd like to get some repro steps for how to create a project that exhibits this issue.

@Ryuurock
Copy link
Author

Ryuurock commented Apr 29, 2020

simplified_version.zip
@BryceLTaylor simplified version

It looks like the result after adding the pen extension is correct

@BryceLTaylor
Copy link
Contributor

@Ryuurock thanks! That's super helpful.

@adroitwhiz
Copy link
Contributor

This looks like it has something to do with scratchfoundation/scratch-render#488. The sprite is testing whether it's touching the color black, but the transparent backdrop seems to be confusing it. If I test this on my "touching white fixes" branch, it works properly.

@kchadha kchadha added this to the June 2020 milestone Jun 4, 2020
@rschamp rschamp modified the milestones: June 2020, July 2020 Jul 9, 2020
@cwillisf
Copy link
Contributor

Current status: we hope this will be fixed by scratchfoundation/scratch-render#676, which is still in progress

@cwillisf
Copy link
Contributor

This appears to be fixed now, probably by scratchfoundation/scratch-render#686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants