Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't bundle schema.org #25

Open
VladimirAlexiev opened this issue Mar 28, 2017 · 2 comments
Open

don't bundle schema.org #25

VladimirAlexiev opened this issue Mar 28, 2017 · 2 comments

Comments

@VladimirAlexiev
Copy link

IMHO you shouldn't bundle the schema.org context but just refer to it.
That way clients can cache the schema context and your context separately, which will provide better opportunities for caching.
If bundled, you risk outdated schema context, or need for more often caching (when either of the two changes).

(related to #24)

@sballesteros
Copy link
Member

Thanks, we bundle the schema.org context because we add some additional requirements to some of the schema.org properties. For instance the schema.org context doesn't specify if the value of some properties should be a @list or @set but for some properties we do (e.g here). I guess we could still just link to the schema.org context and overwrite those property definitions right after.

@VladimirAlexiev
Copy link
Author

Yes, overwriting is much better imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants