Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage of 'size' and 'N' in PackFile figure (?) #6

Open
Byron opened this issue Mar 9, 2011 · 0 comments
Open

Incorrect usage of 'size' and 'N' in PackFile figure (?) #6

Byron opened this issue Mar 9, 2011 · 0 comments

Comments

@Byron
Copy link

Byron commented Mar 9, 2011

In the chapter "The PackFile", the first figure for version 2 index files introduces the variable 'size' as amount of entries. When describing the blocks for sha and crc values, the last entry in the block is referred to as sha1[size] and crc[size] respectively.
I believe it would be better to call it sha1[size-1] and crc[size-1] as the array indices start counting at 0.
The same issue can be found when the variable 'N' refers to the amount of objects at a pack offset larger than 2^32 -1 bits, where the last entry of 64 bit offsets is referred to as 64b_offset[N], which should be 64b_offset[N-1] as the array indices start at 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant