You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that this repository contains a lot of files that can be related to as at least "unnecessary". For example, the build directory is not required to build this project on another person's device. In fact, its presence does more harm than good. Consider a scenario in which someone decides to build your project in a following manner:
Clone the repo
mkdir build && cd build
cmake .. && make -jnproc
This behaviour is to be expected from users as it's a default way of building C++ projects.
Unfortunately, you decided to provide developers with a pre-generated build folder. The configs provided there are not in any way suitable for building he repo on any device with a file structure different from your's.
The conclusion of this tirade is that it is very much advised to delete to build/ folder.
Understandably, committing build folder is a common mistake. However, you managed to also add a binary file a.out. This is simply incorrect. There are absolutely no guarantees that this binary can run on the end-user platform. In my opinion, this file also has to go.
These are the problems that are obvious after a momentary glimpse. Please cleanup the unnecessary files. This is simply not polite to offer repositories of this quality to the public.
The text was updated successfully, but these errors were encountered:
I believe that this repository contains a lot of files that can be related to as at least "unnecessary". For example, the build directory is not required to build this project on another person's device. In fact, its presence does more harm than good. Consider a scenario in which someone decides to build your project in a following manner:
nproc
This behaviour is to be expected from users as it's a default way of building C++ projects.
Unfortunately, you decided to provide developers with a pre-generated build folder. The configs provided there are not in any way suitable for building he repo on any device with a file structure different from your's.
The conclusion of this tirade is that it is very much advised to delete to
build/
folder.Understandably, committing build folder is a common mistake. However, you managed to also add a binary file
a.out
. This is simply incorrect. There are absolutely no guarantees that this binary can run on the end-user platform. In my opinion, this file also has to go.These are the problems that are obvious after a momentary glimpse. Please cleanup the unnecessary files. This is simply not polite to offer repositories of this quality to the public.
The text was updated successfully, but these errors were encountered: