Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shit all over the repository #2

Open
IArtNextI opened this issue Apr 7, 2024 · 0 comments
Open

Shit all over the repository #2

IArtNextI opened this issue Apr 7, 2024 · 0 comments

Comments

@IArtNextI
Copy link

I believe that this repository contains a lot of files that can be related to as at least "unnecessary". For example, the build directory is not required to build this project on another person's device. In fact, its presence does more harm than good. Consider a scenario in which someone decides to build your project in a following manner:

  1. Clone the repo
  2. mkdir build && cd build
  3. cmake .. && make -jnproc
    This behaviour is to be expected from users as it's a default way of building C++ projects.
    Unfortunately, you decided to provide developers with a pre-generated build folder. The configs provided there are not in any way suitable for building he repo on any device with a file structure different from your's.
    The conclusion of this tirade is that it is very much advised to delete to build/ folder.

Understandably, committing build folder is a common mistake. However, you managed to also add a binary file a.out. This is simply incorrect. There are absolutely no guarantees that this binary can run on the end-user platform. In my opinion, this file also has to go.

These are the problems that are obvious after a momentary glimpse. Please cleanup the unnecessary files. This is simply not polite to offer repositories of this quality to the public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant