Implicit conversion to function type produces incorrect symbol occurrence

[ckipp01]

Describe the bug
I've noticed this issue more lately where if I have for example the following small application...

object WebServer {

  def route = getDirectives {
    path("hello") {
      complete(HttpEntity(ContentTypes.`text/html(UTF-8)`, "<h1>Say hello to akka-http</h1>"))
    }
  }

  private lazy val getDirectives = get

  def main(args: Array[String]) {

    implicit val system = ActorSystem("my-system")
    implicit val materializer = ActorMaterializer()
    // needed for the future flatMap/onComplete in the end
    implicit val executionContext = system.dispatcher

    val bindingFuture = Http().bindAndHandle(route, "localhost", 8080)

    println(s"Server online at http://localhost:8080/\nPress RETURN to stop...")
    StdIn.readLine() // let it run until user presses return
    bindingFuture
      .flatMap(_.unbind()) // trigger unbinding from the port
      .onComplete(_ => system.terminate()) // and shutdown when done
  }
}

I would expect that when I "goToDefinition" on get it would bring me to where it is defined. That's what it does in IntelliJ. However, in metals, it seems to bring me to the actual typeDefinition. For example, above it will end up leading me to the implicit def addByNameNullaryApply(directive: Directive0) in akka-land since indeed get is a Directive0. However, I don't want to go to the type definition, but to the position where get is defined.

I have a minimal project that illustrates this issue located here https://github.com/ckipp01/type-def-issue

To Reproduce
Steps to reproduce the behavior:

1. Clone example issue project
2. Compile
3. Attempt to jump to definition on get
4. 😢

Expected behavior
Would jump to where get is defined.

Installation:

• Operating system: macOS
• Editor: Visual Studio Code / Vim
• Metals version: v0.7.6-SNAPSHOT

Search terms
goToDefinition

[olafurpg]

Thank you for reporting! This looks like a semanticdb-scalac bug.

I played around with setting up a worksheet in the Metals test suite to reproduce,

import scala.meta.interactive.InteractiveSemanticdb
val pc = InteractiveSemanticdb.newCompiler()

val x =
  InteractiveSemanticdb
    .toTextDocument(
      pc,
      """
package a
object a {
  implicit class RichInt(x: Int) {
    def soRich(other: Int) = x + other
  }

  val op = 1
  op soRich 2
}
  """,
      List("-P:semanticdb:synthetics:on", "-P:semanticdb:text:on")
    )

scala.meta.internal.mtags.Semanticdbs
  .printTextDocument(x)

pc.askShutdown()

I see that method from akka-http has an advanced signature

akka-http/src/main/scala/akka/http/scaladsl/server/Directive.scala
150:  implicit def addByNameNullaryApply(directive: Directive0): (=> Route) => Route =

The first step would be to reproduce in a minimized code example with no external dependencies and open an issue in scalameta/scalameta

[olafurpg]

Closing this issue in favor of #1967

[olafurpg]

Realized I can transfer the issue.

---

SemanticDB v4.3.0

object a {
  implicit def addByNameNullaryApply(directive: Int): (=> Int) => Int = ???
  
  def bar(fn: (=> Int) => Int): Int = 42
  val get = 42
  get {
    42
  }}

Produces

-- obtained
++ expected
- get/*_empty_.a.addByNameNullaryApply().*/
+ get/*_empty_.a.get.*/

Reported originally by @ckipp01 in https://github.com/scalameta/metals/issues/1052

A good place to start investigating this issue would be to write a test case in TargetedSuite here

scalameta/tests/jvm/src/test/scala/scala/meta/tests/semanticdb/TargetedSuite.scala

Line 181 in 44af455

targeted(

Next, look at all the places where occurrences is updated in TextDocumentOps

scalameta/semanticdb/scalac/library/src/main/scala/scala/meta/internal/semanticdb/scalac/TextDocumentOps.scala

Line 53 in 44af455

val occurrences = mutable.Map[m.Position, String]()