From 76c9fd5dde675d2530f272e40f20354aeecb328d Mon Sep 17 00:00:00 2001 From: ocavue Date: Thu, 9 Sep 2021 12:37:33 +0800 Subject: [PATCH] chore: remove @kyleshevlin/eslint-plugin (#1222) --- package.json | 1 - pnpm-lock.yaml | 12 +----------- support/root/.eslintrc.js | 8 -------- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/package.json b/package.json index 8ec7fe8dde..70d03fc0a4 100644 --- a/package.json +++ b/package.json @@ -136,7 +136,6 @@ "@changesets/changelog-github": "^0.4.0", "@changesets/cli": "^2.16.0", "@jest/types": "^27.0.6", - "@kyleshevlin/eslint-plugin": "^1.3.0", "@linaria/babel-preset": "3.0.0-beta.4", "@linaria/cli": "3.0.0-beta.4", "@linaria/shaker": "3.0.0-beta.4", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index cdc0241ce6..41d84ba506 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -37,7 +37,6 @@ importers: '@changesets/changelog-github': ^0.4.0 '@changesets/cli': ^2.16.0 '@jest/types': ^27.0.6 - '@kyleshevlin/eslint-plugin': ^1.3.0 '@linaria/babel-preset': 3.0.0-beta.4 '@linaria/cli': 3.0.0-beta.4 '@linaria/shaker': 3.0.0-beta.4 @@ -150,7 +149,6 @@ importers: '@changesets/changelog-github': 0.4.0 '@changesets/cli': 2.16.0 '@jest/types': 27.0.6 - '@kyleshevlin/eslint-plugin': 1.3.0_eslint@7.32.0 '@linaria/babel-preset': 3.0.0-beta.4_@babel+core@7.15.0 '@linaria/cli': 3.0.0-beta.4_@babel+core@7.15.0 '@linaria/shaker': 3.0.0-beta.4_@babel+core@7.15.0 @@ -6237,14 +6235,6 @@ packages: twemoji: 13.1.0 dev: true - /@kyleshevlin/eslint-plugin/1.3.0_eslint@7.32.0: - resolution: {integrity: sha512-2yIluqd1+fm9Zjed90zyHMign493LzEUyVq9ys1MnWuZtWAci1cq6fn7RKxT7JJTWpr2EKLVMe0g94EtqfL+kA==} - peerDependencies: - eslint: '>=0.8.0' - dependencies: - eslint: 7.32.0 - dev: false - /@linaria/babel-preset/3.0.0-beta.12_@babel+core@7.15.0: resolution: {integrity: sha512-QMl/f4j18VllyqpANFZkF32Tc1ESFhOo+J71g/0ZyqaMniEyXpk7eizX3eauYYhpJtxjF9BTnGHs3HG7CrlkXw==} peerDependencies: @@ -22799,7 +22789,7 @@ packages: webpack: '>=4.41.1 || 5.x' dependencies: '@babel/runtime': 7.15.3 - react-loadable: 5.5.0_react@17.0.2 + react-loadable: 5.5.0 webpack: 5.51.1 /react-loadable/5.5.0: diff --git a/support/root/.eslintrc.js b/support/root/.eslintrc.js index 39b474a810..1c1a1f698a 100644 --- a/support/root/.eslintrc.js +++ b/support/root/.eslintrc.js @@ -16,9 +16,6 @@ let config = { // For `remirror__lit-components` 'lit', 'lit-a11y', - - // For custom hooks - '@kyleshevlin', ], extends: [ 'eslint:recommended', @@ -276,9 +273,6 @@ let config = { 'react-hooks/exhaustive-deps': 'error', 'react-hooks/rules-of-hooks': 'error', - // See https://kyleshevlin.com/use-encapsulation - '@kyleshevlin/prefer-custom-hooks': 'warn', - // Built in eslint rules 'no-constant-condition': 'off', // To many false positives 'no-empty': 'warn', @@ -348,7 +342,6 @@ let config = { '@typescript-eslint/no-non-null-assertion': 'off', // Makes writing tests more convenient '@typescript-eslint/no-use-before-define': 'off', 'react/display-name': 'off', - '@kyleshevlin/prefer-custom-hooks': 'off', }, }, { @@ -523,7 +516,6 @@ if (process.env.FULL_ESLINT_CHECK) { // Set up rules to be excluded in the markdown blocks. rules: { - '@kyleshevlin/prefer-custom-hooks': 'off', 'simple-import-sort/exports': 'warn', 'simple-import-sort/imports': 'warn', 'unicorn/filename-case': 'off',