Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are several "syntactic error" in your code #1

Open
Ethanwl opened this issue Aug 9, 2020 · 1 comment
Open

There are several "syntactic error" in your code #1

Ethanwl opened this issue Aug 9, 2020 · 1 comment

Comments

@Ethanwl
Copy link

Ethanwl commented Aug 9, 2020

I'd like to make sure whether this is the code to run your experiments in your paper.
There are several "syntactic error" in your code. For example, there is an unnecessary right bracket:

def train_epoch(model, train_batches, test_batches, optimizer_step, timer, world_size, test_time_in_total=True, compress=None, method=None, K=None, V=None, qstates=None)):

SyntaxError: positional argument follows keyword argument:

train(model, opt, train_batches, test_batches, epochs, args.master_address, args.world_size, args.rank, loggers=(TableLogger(), TSV), timer=timer, test_time_in_total=False, args.compress, args.method, args.ratio, args.threshold, args.qstates)

@ahmedcs
Copy link
Collaborator

ahmedcs commented Aug 9, 2020

Dear @Ethanwl,
thank you for pointing out these errors, we have fixed them, please pull the recent version and let us know if you have further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants