Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use depths not heights #14

Closed
dbhart opened this issue Sep 7, 2024 · 1 comment
Closed

Use depths not heights #14

dbhart opened this issue Sep 7, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dbhart
Copy link
Collaborator

dbhart commented Sep 7, 2024

The configuration files specify that EOT and OBI values are "depths", however that is not currently true. They are specified as heights above the original TD, or, in a way that is not documented, if negative values they are the distance above the top of the insoluble pile top. This needs to be changed and a manner to specify depths below ZDP finalized. This could either by providing two different options, such as a "positions-are-depths" being true or false, or using "-" to indicate "below ZDP". Whatever the change is, this needs to be very clear in the documentation.
@dbhart dbhart added bug Something isn't working enhancement New feature or request documentation Improvements or additions to documentation and removed bug Something isn't working labels Sep 7, 2024
@dbhart dbhart mentioned this issue Oct 31, 2024
Merged
@dbhart
Copy link
Collaborator Author

dbhart commented Oct 31, 2024

Fixed by #84

@dbhart dbhart closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbhart