Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] zabbix_return should also consider zabbix_agent2.conf #61313

Open
Flowdalic opened this issue Dec 2, 2021 · 3 comments
Open

[BUG] zabbix_return should also consider zabbix_agent2.conf #61313

Flowdalic opened this issue Dec 2, 2021 · 3 comments
Assignees
@krionbsd
Labels
Feature new functionality including changes to functionality and code refactors, etc. Returners
Milestone
Approved

Comments

@Flowdalic
Copy link

As of now, zabbix_return.py only considers zabbix_agentd.conf, but for zabbix_sender the configuration from Zabbix agent 2, zabbix_agent2.conf, is also suitable.
@Flowdalic Flowdalic added Bug broken, incorrect, or confusing behavior needs-triage labels Dec 2, 2021
@welcome
Copy link

welcome bot commented Dec 2, 2021

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@OrangeDog
Copy link
Contributor

It should probably be configurable, using config.get and defaulting to the current path.

The formula uses the key zabbix.lookup.agent.config for this. Sharing it might be a good idea.

See also saltstack-formulas/zabbix-formula#154

@OrangeDog OrangeDog added Feature new functionality including changes to functionality and code refactors, etc. Returners and removed Bug broken, incorrect, or confusing behavior needs-triage labels Dec 3, 2021
@OrangeDog OrangeDog added this to the Approved milestone Dec 3, 2021
@Flowdalic Flowdalic mentioned this issue Dec 3, 2021
Closed
@Flowdalic
Copy link
Author

Sorry, I already made a PR for this, but failed to link the PR correctly to this issue.

Flowdalic added a commit to Flowdalic/salt that referenced this issue Dec 3, 2021
@Flowdalic
zabbix_return: also consider zabbix_agent2.conf
34ab329 
It is also possible to use the configuration file of Zabbix's Agent 2
for zabbix_sender, hence this file also also be considered as argument
for zabbix_sender's --config command line paramter.

Fixes saltstack#61313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krionbsd krionbsd

Labels
Feature new functionality including changes to functionality and code refactors, etc. Returners
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@Flowdalic @OrangeDog @krionbsd