Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Comment not present in zone xml file when using *_ports #43

Closed
mymindstorm opened this issue May 10, 2020 · 1 comment
Closed
Labels

Comments

@mymindstorm
Copy link

Your setup

Formula commit hash / release tag

v1.0.0

Versions reports (master & minion)

3000.2

Pillar / config used

Working:

firewalld:
  zones:
    public:
      ports:
        - comment: "test"
          port: 8080
          protocol: tcp

Not working:

firewalld:
  zones:
    public:
      test_ports:
        - comment: "test"
          port: 8080
          protocol: tcp

Bug details

Describe the bug

When using *_ports instead of ports in pillar config, the comment is not present in rendered /etc/firewalld/zones/public.xml

Steps to reproduce the bug

Use a the above pillar config.

Expected behaviour

Comment is rendered to /etc/firewalld/zones/public.xml

@mymindstorm mymindstorm changed the title [BUG] [BUG] Comment not present in zone xml file when using *_ports May 10, 2020
@mymindstorm
Copy link
Author

I dumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant