Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various documentation issues #638

Open
Elias-Graf opened this issue Dec 24, 2024 · 2 comments
Open

Various documentation issues #638

Elias-Graf opened this issue Dec 24, 2024 · 2 comments

Comments

@Elias-Graf
Copy link

image

Seems like the anchor referenced here:

https://github.com/salsa-rs/salsa/blob/88a1d7774d78f048fbd77d40abca9ebd729fd1f0/book/src/tutorial/debug.md?plain=1#L25C1-L29C4

is missing from examples/calc/ir.rs. I sadly don't have a clue how any of this works, otherwise I would have made a PR :D.

@Elias-Graf Elias-Graf changed the title "Forwarding to the ordinary Debug trait" example missing Various documentation issues Dec 27, 2024
@Elias-Graf
Copy link
Author

https://salsa-rs.github.io/salsa/tutorial/accumulators.html#defining-the-parser-reporting-errors
image

should be something like:

        Diagnostic(format!(
            "Error in file {}: {:?}\n",
            file.path(db)
                .file_name()
                .unwrap_or_else(|| "<unknown>".as_ref())
                .to_string_lossy(),
            error,
        ))
        .accumulate(db);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant