Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RouteSettings to ModalBottomSheetProps #737

Open
dumazy opened this issue Jan 14, 2025 · 0 comments
Open

Add RouteSettings to ModalBottomSheetProps #737

dumazy opened this issue Jan 14, 2025 · 0 comments
Assignees
@salim-lachdhaf
Labels
enhancement New feature or request

Comments

@dumazy
Copy link

dumazy commented Jan 14, 2025

ModalBottomSheetProps is an almost perfect grouping of all possible properties for showModalBottomSheet, however RouteSettings is still missing.

Our telemetry uses a NavigatorObserver to group events by view, based on the route name.
Adding RouteSettings? to ModalBottomSheetProps to then pass along the showModalBottomSheet call would allow us to group events together for this open dropdown.
@salim-lachdhaf salim-lachdhaf self-assigned this Jan 16, 2025
@salim-lachdhaf salim-lachdhaf added the enhancement New feature or request label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salim-lachdhaf salim-lachdhaf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dumazy @salim-lachdhaf