Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANN] Extensions design discussion #134

Open
Etiene opened this issue Oct 5, 2016 · 1 comment
Open

[ANN] Extensions design discussion #134

Etiene opened this issue Oct 5, 2016 · 1 comment

Comments

@Etiene
Copy link
Member

Etiene commented Oct 5, 2016

Now that I'm back to work, one of the things that I want to tackle in Sailor is a feature to add extensions (or plugins, not sure how we should call it yet) to it.

The main reason I want to do that is to allow making new features that are not necessarily part of the Sailor so it doesn't become bloated. And my main motivator to do this, are two pending pull requests, one for adding an admin center another one for integrating sailor with elastic search, that I want to transform as not a part of default installation, but allow these features to be installed as a separate package.

I closed the past issue (#82) because this is something that I already started working before, and it was partly implemented, but I decided to reboot the discussion and start working on this again from scratch.

We can discuss this here, on this issue, or on a more synchronous way, on the gitter chat: https://gitter.im/sailorproject/extensions

Issues to think about

  • naming this feature
    • extensions, plugins, add-ons, other??
  • namespacing of extensions
    • what could happen when extensions have conflicting names
    • what could happen when extension functions conflict with core functions?
  • where the extension files should go
  • how would they affect routing
  • having a modified version of an extension
  • how would the extensions be installed and patched
    • luarocks to install + sailor command line client to activate it?
  • how should extension specific configuration be done
    • where should it go
  • activating and deactivating extensions in a sailor app
  • what happens when we have multiple sailor apps running
  • how to load the extensions
    • modifying the routing process?
@Etiene
Copy link
Member Author

Etiene commented Feb 7, 2017

I'm finally settling in the new country and I just came back from FOSDEM, so I guess this is a good time to restart this discussion.

@d9k, @paulcuth, @felipedaragon, @rnikhil275, @VaishaliJain, @soapdog, @develCuy
What are your opinions? :) Do you have any points you want to raise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants