Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sh format: improve stampfile handling #556

Merged
merged 1 commit into from
Mar 3, 2025
Merged

sh format: improve stampfile handling #556

merged 1 commit into from
Mar 3, 2025

Conversation

cebtenzzre
Copy link
Contributor

  • mktemp in /tmp
  • don't assume $0 is a file
  • remove stampfiles at exit
  • don't create stampfiles if -n is passed

Closes #554

@cebtenzzre
sh format: improve stampfile handling
3c0ec57 
- mktemp in /tmp
- don't assume $0 is a file
- remove stampfiles at exit
- don't create stampfiles if -n is passed

Closes sahib#554
@cebtenzzre cebtenzzre linked an issue Aug 9, 2022 that may be closed by this pull request
STAMPFILE for maintaining directory timestamps is not deleted when executing rmlint.sh using -n (dry run) #554
Closed
@vassilit
Copy link
Collaborator

vassilit commented Mar 2, 2025

Closes: #667

@RayOei
Copy link
Collaborator

RayOei commented Mar 2, 2025 •
edited
Loading

You are on a role @vassilit 🎉
Will it help to label all these, which are part of develop, so we get a better overview of which issues can be closed when get to that point that the merge result is stable and reviewed?
I get the idea that the administration of what is done where in which PR/commit is a bit lacking, at least for me 😊

@vassilit
Copy link
Collaborator

vassilit commented Mar 2, 2025

This one isn't part of develop yet. It can still be rebased to any branch.
I wouldn't do too much bugfixes until the situation of develop has improved.

@vassilit vassilit linked an issue Mar 3, 2025 that may be closed by this pull request
Ensure mktemp creates files in a apropiate directory #667
Open
@vassilit vassilit changed the base branch from develop to test-gh-change-base March 3, 2025 18:07
@vassilit vassilit changed the base branch from test-gh-change-base to develop March 3, 2025 18:08
@vassilit
Copy link
Collaborator

vassilit commented Mar 3, 2025

Well, Github's not git :) The rebase is not perfect.

I've rebased your commit to master in the branch stampfile-fixes.

@vassilit vassilit mentioned this pull request Mar 3, 2025
Merged
@vassilit vassilit merged commit 16a40e1 into sahib:develop Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vassilit vassilit vassilit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.3 Ludicrous Lemur Bugfixes
3 participants
@cebtenzzre @vassilit @RayOei