Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Center #6

Closed
zleypner opened this issue Jan 21, 2025 · 9 comments
Closed

Notification Center #6

zleypner opened this issue Jan 21, 2025 · 9 comments

Comments

@zleypner
Copy link
Contributor

zleypner commented Jan 21, 2025

Implement Preferences Settings
Description
Create a Preferences settings page for managing notification and system preferences with toggleable options.
Requirements
UI Components:

Settings categories
Toggle switches
Save/Cancel buttons
Confirmation dialogs

Features:

Email notification settings
Push notification preferences
Security alert settings
System update preferences
Language/locale settings

Use shadcn Components:

Switch
Form
Card
Button
Dialog
Select

Acceptance Criteria:

Functioning preference toggles
Settings persistence after refresh
Change confirmation dialogs
Design system compliance
Responsive layout
Accessibility standards met

Resources:

Design system documentation
shadcn/ui docs
Project repository

Follow this Figma

Image

Make sure to follow the Git Guidelines for Atomic Commits and read Contributing Guide

The Pull request needs to have the format mentioned below in the Git Guideline

@pragmaticAweds
Copy link
Contributor

Is it okay if I take this?

@Supa-mega
Copy link

Could I be assigned to this?

@Jemiiah
Copy link

Jemiiah commented Jan 22, 2025

Hello @zleypner, I'm Jeremiah, a frontend web3 developer. I have contributed to previous OD hacks. i have made over 90+ contribution in past OD Hacks here's my OD Hack profile: https://app.onlydust.com/Jemiiah I intend to solve this issue with an ETA of 48 hours. I would be a returning contributor to this repository and i would love the pleasure of contributing to this issue

@Kingsuite
Copy link

Mind if I take this issue?

@ekumamatthew
Copy link
Contributor

I’d love to work on this task.

@pragmaticAweds
Copy link
Contributor

Hi @JosueBrenes

Thanks for the opportunity, I checked the figma link in the repository, but I can't find the notification UI. For confirmation, is the UI attached here the one i should proceed with?

@pragmaticAweds
Copy link
Contributor

Hi @zleypner

Please can I know the particular design will be implementing, because I have implement almost two, only to find out, the design has changed. Please I will appreciate if I can the specific UI to implement. Thank you

@zleypner zleypner changed the title Notification Center Notification Center (Create new alert) Jan 28, 2025
@zleypner zleypner changed the title Notification Center (Create new alert) Notification Center Jan 28, 2025
@zleypner
Copy link
Contributor Author

Hello @pragmaticAweds , Is the current figma. Please proceed with a draft PR. If you have any question I will be glad to assist.

@zleypner
Copy link
Contributor Author

zleypner commented Jan 28, 2025

Hello @pragmaticAweds

As per our conversation on Telegram, on regard of issues with the PR, here’s a quick guide to help you contribute to the repository and address Issue #6:


Steps to Contribute:

  1. Fork the Repository:

    • Go to the dApp-SafeTrust repository.
    • Click the "Fork" button at the top right corner. This will create a copy of the repo under your GitHub account.
  2. Clone Your Fork:

    • Clone your forked repository to your local machine using:
      git clone https://github.com/YOUR-USERNAME/dApp-SafeTrust.git
    • Replace YOUR-USERNAME with your GitHub username.
  3. Create a New Branch:

    • Navigate to the cloned repository:
      cd dApp-SafeTrust
    • Create a new branch specifically for Issue Notification Center #6. The branch name should be feature/new-notification-center-page:
      git checkout -b feature/new-notification-center-page
    • This naming convention helps us easily identify the purpose of the branch.
  4. Make Your Changes:

    • Address the changes required for Issue Notification Center #6 in the codebase.
    • Save your changes and stage them:
      git add .
  5. Commit Your Changes:

    • Commit your changes with a clear and descriptive message:
      git commit -m "Feat: Added new notification center page - Resolves Issue #6"
  6. Push Your Branch:

    • Push your branch to your forked repository:
      git push origin feature/new-notification-center-page
  7. Create a Pull Request (PR):

    • Go to your forked repository on GitHub.
    • Click on "Compare & pull request".
    • Ensure the base branch is main (from the original safetrustcr/dApp-SafeTrust repo) and the compare branch is your new branch (feature/new-notification-center-page).
    • Add a title and description explaining your changes. Reference Issue Notification Center #6 in the description like this:
      Closes #6
      
      This will automatically link the PR to the issue.
    • Submit the pull request.
  8. Wait for Review:

    • Your PR will be reviewed by the maintainers. If any changes are requested, make the necessary updates and push them to the same branch.
  9. Merge into Main:

    • Once your PR is approved, it will be merged into the main branch by the maintainers.

Important Notes:

  • Do not push directly to the main branch. All changes must go through a pull request for review.
  • Use the branch name feature/new-notification-center-page to ensure consistency.
  • If you need help or have questions, feel free to ask me

Thanks for contributing to the dApp-SafeTrust project! Your work is greatly appreciated. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants