Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js package #14

Open
pantchox opened this issue Apr 22, 2021 · 5 comments
Open

Node.js package #14

pantchox opened this issue Apr 22, 2021 · 5 comments
Assignees

Comments

@pantchox
Copy link

Hi,
thanks for this great wrapper.

I think from node version 15.14.0 there is webcrypto in the official crytpo library.
like so: require('crypto').webcrypto
or using https://github.com/PeculiarVentures/webcrypto
this might be a good idea to offer isomorphic package.

thanks!

@jackHedaya
Copy link
Contributor

Hey there! Wondering if there are any updates on this as I was just about to build my own wrapper on top of opencrypto and the crypto package. Wouldn't mind taking a crack at it if it's not under development.

@PeterBielak
Copy link
Member

Hi @pantchox thank you for the suggestion! It is very appreciated. Apologies for the late reply, I've been very busy during the last few months. I'd be glad to include this option. Feel free to open a PR.

@jackHedaya
Copy link
Contributor

We have multiple options of going about this. @PeterBielak do you think the isomorphic-crypto package or a custom require('crypto') situation is better?

@PeterBielak
Copy link
Member

@jackHedaya I'd prefer to build a custom solution as to prevent usage of any third party dependencies.

@jackHedaya
Copy link
Contributor

So thinking we could use crypto.webcrypto but getting caught on the thought that it was only introduced in Node v12. Maybe we should use a shim but at that point we're using a 3rd party package anyways. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants