-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete owner’s delegated keys when the owner is removed #1850
Comments
I think this has to be fixed in the transaction service. Only the delegator or delegate can remove a delegate.. If the delegator is removed as an owner by someone else, this other owner can not sign the remove delegate payload. Our indexer should pick up that an owner got removed and delete all delegates where this owner was the delegator. |
Makes sense. @Uxio0 wdyt? |
Makes sense @katspaugh , could you open an issue on the tx service? |
@Uxio0 Please feel free to transfer this one, I don't have the right permissions for that repo. I gave you admin rights in this one. |
I don't have permissions to transfer this issue 😅 |
@moisses89 Delegates should only be deleted for Delegates for that owner if the Safe is set. For delegates valid across multiple Safes it shouldn't be deleted |
A feature request from the Yearn team:
If an owner who an added a delegate key has been removed, that delegate is no longer valid. So it would be good to remove all delegates by that owner when the owner is removed/replaced.
The text was updated successfully, but these errors were encountered: