Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete owner’s delegated keys when the owner is removed #1850

Closed
katspaugh opened this issue Jan 24, 2024 · 6 comments · Fixed by #1957
Closed

Delete owner’s delegated keys when the owner is removed #1850

katspaugh opened this issue Jan 24, 2024 · 6 comments · Fixed by #1957
Assignees
Labels
enhancement New feature or request

Comments

@katspaugh
Copy link
Member

A feature request from the Yearn team:

If an owner who an added a delegate key has been removed, that delegate is no longer valid. So it would be good to remove all delegates by that owner when the owner is removed/replaced.

@katspaugh katspaugh added the enhancement New feature or request label Jan 24, 2024
@schmanu
Copy link
Member

schmanu commented Jan 25, 2024

I think this has to be fixed in the transaction service. Only the delegator or delegate can remove a delegate.. If the delegator is removed as an owner by someone else, this other owner can not sign the remove delegate payload.

Our indexer should pick up that an owner got removed and delete all delegates where this owner was the delegator.

@katspaugh
Copy link
Member Author

Makes sense. @Uxio0 wdyt?

@Uxio0
Copy link
Member

Uxio0 commented Jan 26, 2024

Makes sense @katspaugh , could you open an issue on the tx service?

@katspaugh
Copy link
Member Author

@Uxio0 Please feel free to transfer this one, I don't have the right permissions for that repo. I gave you admin rights in this one.

@Uxio0
Copy link
Member

Uxio0 commented Jan 26, 2024

I don't have permissions to transfer this issue 😅

@Uxio0 Uxio0 transferred this issue from safe-global/safe-wallet-monorepo Feb 1, 2024
@Uxio0
Copy link
Member

Uxio0 commented Feb 19, 2024

@moisses89 Delegates should only be deleted for Delegates for that owner if the Safe is set. For delegates valid across multiple Safes it shouldn't be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants