Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GET /balances/usd] - returns 0 for fiatConversion and fiatBalance #1759

Closed
kryptocodes opened this issue Nov 13, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@kryptocodes
Copy link

Bug
The transaction API routinely returns 0 balances (fiatConversion & fiatBalance) for all tokens when queries are made to retrieve the balance of a particular safe address in USD, even though the safe address does contain non-zero balances.

To Reproduce

Environment:

Chain ID: 1 (Ethereum Mainnet)
Fiat Code: USD

Expected behavior
It supposed to return the fiatConversion and fiatBalance of the token

Additional notes
The same requests made to the safe-client endpoint return accurate fiat balances & fiatConversion for the tokens at the specified safe address.

https://safe-client.safe.global/v1/chains/1/safes/0x0DA0C3e52C977Ed3cBc641fF02DD271c3ED55aFe/balances/usd?trusted=false

@kryptocodes kryptocodes added the bug Something isn't working label Nov 13, 2023
@kryptocodes kryptocodes changed the title /safe/balances/usd - returns 0 for fiatConversion and fiatBalance [GET /balances/usd] - returns 0 for fiatConversion and fiatBalance Nov 14, 2023
@moisses89
Copy link
Member

@kryptocodes price calculation on transaction service will be discontinued. https://forum.safe.global/t/important-update-changes-to-token-pricing-in-our-api/4392
Sorry about any inconvenience that this can cause.

@moisses89 moisses89 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@moisses89
Copy link
Member

Just to clarify, safe-client-gateway still return prices from other sources. This only affects to the safe transaction service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants