Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe4337Module #38

Open
Malikrehman00107 opened this issue Oct 1, 2024 · 22 comments
Open

Safe4337Module #38

Malikrehman00107 opened this issue Oct 1, 2024 · 22 comments

Comments

@Malikrehman00107
Copy link

We are using this address for BSC-MAINNET : https://bscscan.com/address/0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226#code

which is already 0.3.0 but we are getting this error :

Safe4337Module and/or AddModulesLib not available for chain 56 and modules version 0.2.0

@remedcu
Copy link
Member

remedcu commented Oct 1, 2024

This could be because you are using v2.2.1 of the safe-modules-deployment package.

@Malikrehman00107
Copy link
Author

then what i should do ?

@remedcu
Copy link
Member

remedcu commented Oct 1, 2024

@Malikrehman00107
Copy link
Author

How we can check the version of safe module?

@Malikrehman00107
Copy link
Author

we dont know our safe module version !

@remedcu
Copy link
Member

remedcu commented Oct 1, 2024

You can use npm list command. Source

@Malikrehman00107
Copy link
Author

Can we connect over a meet cause or prod is down! we are literally stuck!

Please!

@remedcu
Copy link
Member

remedcu commented Oct 1, 2024

  1. Could you tell me what is the issue and any steps to reproduce that error?

  2. Are you able to access the BNB Mainnet Safe 4337 Modules network address through this now that you have updated the version?

@Malikrehman00107
Copy link
Author

Thank you for your response :

Yes , wec can access our safe and version is : 1.4.1+L2 Latest version
This is what we add in the module sourcing from :
https://github.com/safe-global/safe-modules-deployments/commit/b9304bf8c4ec77cbc0831e2f3f7d4d1aae196f1d#diff-b6125fbf927e45f[…]7a3c0bc9c3fccb5ef1ceb

Screenshot 2024-10-01 at 10 19 51 AM

https://bscscan.com/address/0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226

Error: Safe4337Module and/or AddModulesLib not available for chain 56 and modules version 0.2.0

@remedcu
Copy link
Member

remedcu commented Oct 1, 2024

The address (0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226) you have shared is Safe4337Module v0.3.0.

The error you shared mentions v0.2.0 which does not have an official deployment made yet in BNB Chain (chain id: 56). If you want to use an older version (v0.2.0), you can go to safe-modules repo, and checkout 4337/v0.2.0 tag to deploy these.

It is recommended to use the latest version v0.3.0 of Safe4337Module with the SafeModuleSetup (instead of AddModulesLib).

@Malikrehman00107
Copy link
Author

It is recommended to use the latest version v0.3.0 of Safe4337Module with the SafeModuleSetup (instead of AddModulesLib).

So in this case what we need to do?

@Malikrehman00107
Copy link
Author

@faisal-anwar825

Have a look please!

@Malikrehman00107
Copy link
Author

@remedcu if you can please tell what we have to do exactly?

upgrade the v0.3.0 of Safe4337Module so it is compatible with "address version" ?

if yes how we can do it?

please guide

@mmv08
Copy link
Member

mmv08 commented Oct 1, 2024

Hey @Malikrehman00107, we can't help you because we cannot understand the issue. @remedcu had asked to provide the complete reproduction steps so we can help you. Please cooperate and kindly provide these, thanks

@Malikrehman00107
Copy link
Author

Sure !

So we deploy a safe on Binance & ETH Mainnet.

Safe BNB :bnb:0xb86b48Cfa46B3Bdf8f584B8A78B4fEEd1B54AC19

Safe ETH : eth:0x2F36fa9D3543bb2fdb3B74fc50cF3ED2269b2328

Version of both safe : 1.4.1

we are using relays using this method : https://docs.safe.global/sdk/relay-kit/guides/4337-safe-sdk

This is what we add in the module sourcing from :
https://github.com/safe-global/safe-modules-deployments/commit/b9304bf8c4ec77cbc0831e2f3f7d4d1aae196f1d#diff-b6125fbf927e45f[…]7a3c0bc9c3fccb5ef1ceb

For BNB for example we add : https://bscscan.com/address/0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226

Error: Safe4337Module and/or AddModulesLib not available for chain 56 and modules version 0.2.0

how we can solve it ?

@Malikrehman00107
Copy link
Author

@remedcu @mmv08 If you can please guide?

@faisal-anwar825
Copy link

@remedcu Can you please guide us a little bit about where this safe-modules-deployment package is used. Because we deployed a safe and then added Safe4337Module module from safe.global UI through transaction builder. First we added 0xa581c4A4DB7175302464fF3C06380BC3270b4037 which we believe is the address for 0.2.0 version of Safe4337Module module but when we tried to make a transaction it gave an error saying

Error: Safe4337Module and/or AddModulesLib not available for chain 56 and modules version 0.2.0

so then we added 0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226 which is 0.3.0 version of Safe4337Module. But we are still getting the same error. We are unable to identify where exactly is the problem.

@Malikrehman00107
Copy link
Author

@remedcu please!

@Malikrehman00107
Copy link
Author

@remedcu please have a look !

@Malikrehman00107
Copy link
Author

@remedcu please understand this is a prod issue, we need to fix it ASAP and early attention is highly appreciated please
!

@remedcu
Copy link
Member

remedcu commented Oct 4, 2024

Could you please use the latest release of the relay-kit: https://www.npmjs.com/package/@safe-global/relay-kit/v/3.2.1

With v0.2.0, currently the SDK does not support v0.3.0.

@Malikrehman00107
Copy link
Author

@faisal-anwar825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants