Add chainId parameter on decoder endpoint #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
force-pushed
the
add-chain-id-endpoint
branch
from
5b18ae6 to
c4861a6
Compare
Pull Request Test Coverage Report for Build 12884889715Details
💛 - Coveralls |
moisses89
approved these changes
Jan 22, 2025
| "type": "function", | ||
| }, | ||
| ], | ||
| ) |
There was a problem hiding this comment.
I would preffer ABIS in mock files to keep clean the tests.
There was a problem hiding this comment.
Agree, I will merge both PRs and then do it, if not I will have to fix conflicts
moisses89
reviewed
Jan 22, 2025
| client: TestClient | ||
|
|
||
| @classmethod | ||
| def setUpClass(cls): | ||
| cls.client = TestClient(app) | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
Should uses async setup and async teardown?
There was a problem hiding this comment.
If the functions inside are not async, I wouldn't
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chain_idsupport for decoding endpoint #71