Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy implementation address to contract and download metadata #59

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add proxy implementation address to contract and download metadata #59

merged 2 commits into from
Jan 13, 2025

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez force-pushed the add-proxy-information-to-contract branch from af615fe to b6c2d61 Compare January 9, 2025 15:29
@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review January 9, 2025 15:32
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner January 9, 2025 15:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12693041738

Details

  • 19 of 21 (90.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.588%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/workers/tasks.py 10 12 83.33%
Totals Coverage Status
Change from base Build 12688135543: 0.2%
Covered Lines: 832
Relevant Lines: 889
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12693105114

Details

  • 19 of 21 (90.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.588%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/workers/tasks.py 10 12 83.33%
Totals Coverage Status
Change from base Build 12688135543: 0.2%
Covered Lines: 832
Relevant Lines: 889
💛 - Coveralls

moisses89
moisses89 approved these changes Jan 13, 2025
View reviewed changes
app/workers/tasks.py Outdated Show resolved Hide resolved
@falvaradorodriguez @moisses89
Apply PR suggestion
34453de 
Co-authored-by: Moisés  <[email protected]>
@falvaradorodriguez falvaradorodriguez merged commit 7b42103 into main Jan 13, 2025
5 checks passed
@falvaradorodriguez falvaradorodriguez deleted the add-proxy-information-to-contract branch January 13, 2025 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proxy information to contract
3 participants
@falvaradorodriguez @coveralls @moisses89