-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contracts endpoint #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
force-pushed
the
add_contracts_endpoint
branch
2 times, most recently
from
December 19, 2024 08:47
36cb892
to
a4b4315
Compare
Pull Request Test Coverage Report for Build 12502657968Details
💛 - Coveralls |
Uxio0
requested changes
Dec 19, 2024
app/routers/contracts.py
Outdated
if not fast_is_checksum_address(address): | ||
raise HTTPException(status_code=400, detail="Address is not checksumed") | ||
|
||
contracts_service = ContractService(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing the request
to the service and instantiating one service for every client does not sound right to me
Uxio0
approved these changes
Dec 24, 2024
moisses89
force-pushed
the
add_contracts_endpoint
branch
from
December 26, 2024 10:15
5620389
to
00ec158
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue related
Close #12