Add the RabbitMQ consumer #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
falvaradorodriguez
commented
Dec 12, 2024
falvaradorodriguez
commented
- Closes Add the RabbitMQ consumer #14
falvaradorodriguez
force-pushed
the
add-the-rabbitmq-consumer
branch
from
9747895 to
a3c935b
Compare
Pull Request Test Coverage Report for Build 12353635207Details
💛 - Coveralls |
Uxio0
approved these changes
Dec 13, 2024
app/services/events.py
Outdated
|
|
||
| class EventsService: | ||
|
|
||
| @classmethod |
There was a problem hiding this comment.
We shouldn't use classmethod and staticmethod for the services, they should be instantiated
There was a problem hiding this comment.
Updated here
moisses89
requested changes
Dec 16, 2024
Co-authored-by: Moisés <[email protected]>
moisses89
approved these changes
Dec 16, 2024
| """ | ||
|
|
||
| pass | ||
|
|
There was a problem hiding this comment.
I would move the exceptions to exceptions.py inside of the queue package.
There was a problem hiding this comment.
👍 Moved here
app/tests/services/test_events.py
Outdated
| valid_event = {"chainId": "123", "type": "transaction"} | ||
| self.assertTrue(EventsService.is_event_valid(valid_event)) | ||
|
|
||
| def test_is_event_invalid(self): |
There was a problem hiding this comment.
I think that this test could be a continuation from the previous one. I mean, reading the test function I was thinking wrongly that there was a is_event_invalid funtion.
There was a problem hiding this comment.
Makes sense. Updated here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.