From 0ca3967f1242645f377382cc53293cbb611a01e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADnez?= Date: Wed, 3 Aug 2022 11:50:20 +0200 Subject: [PATCH 1/4] Fix postinstall script --- packages/safe-core-sdk/package.json | 2 +- .../safe-core-sdk/scripts/{postinstall.ts => postinstall.js} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename packages/safe-core-sdk/scripts/{postinstall.ts => postinstall.js} (100%) diff --git a/packages/safe-core-sdk/package.json b/packages/safe-core-sdk/package.json index 048f851e9..aea97e4b7 100644 --- a/packages/safe-core-sdk/package.json +++ b/packages/safe-core-sdk/package.json @@ -13,7 +13,7 @@ "scripts": { "unbuild": "rimraf dist artifacts deployments cache .nyc_output", "build": "hardhat compile && tsc", - "postinstall": "ts-node scripts/postinstall.ts", + "postinstall": "node scripts/postinstall.js", "test:ganache:web3:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:web3:v1.3.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.3.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:ethers:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=ethers && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", diff --git a/packages/safe-core-sdk/scripts/postinstall.ts b/packages/safe-core-sdk/scripts/postinstall.js similarity index 100% rename from packages/safe-core-sdk/scripts/postinstall.ts rename to packages/safe-core-sdk/scripts/postinstall.js From 968e88e7ff56eed83ab43b18d3870082db1860d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADnez?= Date: Wed, 3 Aug 2022 12:31:01 +0200 Subject: [PATCH 2/4] Remove postinstall script --- packages/safe-core-sdk/package.json | 2 +- packages/safe-core-sdk/scripts/postinstall.js | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) delete mode 100644 packages/safe-core-sdk/scripts/postinstall.js diff --git a/packages/safe-core-sdk/package.json b/packages/safe-core-sdk/package.json index aea97e4b7..6c4926e22 100644 --- a/packages/safe-core-sdk/package.json +++ b/packages/safe-core-sdk/package.json @@ -13,7 +13,7 @@ "scripts": { "unbuild": "rimraf dist artifacts deployments cache .nyc_output", "build": "hardhat compile && tsc", - "postinstall": "node scripts/postinstall.js", + "postinstall": "echo '⚠️ the \"signTransaction\" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.'", "test:ganache:web3:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:web3:v1.3.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.3.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:ethers:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=ethers && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", diff --git a/packages/safe-core-sdk/scripts/postinstall.js b/packages/safe-core-sdk/scripts/postinstall.js deleted file mode 100644 index 73fa05e04..000000000 --- a/packages/safe-core-sdk/scripts/postinstall.js +++ /dev/null @@ -1,7 +0,0 @@ -function postInstall() { - console.warn( - `⚠️ the "signTransaction" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.` - ) -} - -postInstall() From 36750e013ab14f8488234e8e3c17b3dc3a68c1b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADnez?= Date: Wed, 3 Aug 2022 13:11:07 +0200 Subject: [PATCH 3/4] Remove postinstall script --- packages/safe-core-sdk/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/safe-core-sdk/package.json b/packages/safe-core-sdk/package.json index 6c4926e22..eeabe7993 100644 --- a/packages/safe-core-sdk/package.json +++ b/packages/safe-core-sdk/package.json @@ -13,7 +13,6 @@ "scripts": { "unbuild": "rimraf dist artifacts deployments cache .nyc_output", "build": "hardhat compile && tsc", - "postinstall": "echo '⚠️ the \"signTransaction\" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.'", "test:ganache:web3:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:web3:v1.3.0": "export TEST_NETWORK=ganache && export ETH_LIB=web3 && export SAFE_VERSION=1.3.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", "test:ganache:ethers:v1.2.0": "export TEST_NETWORK=ganache && export ETH_LIB=ethers && export SAFE_VERSION=1.2.0 && hardhat --network localhost deploy && nyc hardhat --network localhost test", From 560b5ec22e0afc46732d4b1b3bfb37de92a1cff4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADnez?= Date: Wed, 3 Aug 2022 13:15:13 +0200 Subject: [PATCH 4/4] safe-core-sdk v2.4.1 --- packages/safe-core-sdk/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/safe-core-sdk/package.json b/packages/safe-core-sdk/package.json index eeabe7993..190ef42fb 100644 --- a/packages/safe-core-sdk/package.json +++ b/packages/safe-core-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@gnosis.pm/safe-core-sdk", - "version": "2.3.0", + "version": "2.4.1", "description": "Safe Core SDK", "main": "dist/src/index.js", "typings": "dist/src/index.d.ts",