Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null in place of filtering Safe overviews #2285

Open
iamacook opened this issue Jan 22, 2025 · 0 comments
Open

Return null in place of filtering Safe overviews #2285

iamacook opened this issue Jan 22, 2025 · 0 comments

Comments

@iamacook
Copy link
Member

Description

We gracefully handle chains with throw when fetching Safe overviews. We do this in order to not block the UI should a chain-specific Transaction Service be misconfigured, etc.

Currently, errorneous chains are filtered out and there is no feedback given to the user. We should, instead, return null instead in a similar fashion to our v2 owner endpoint.

Requirements

  • Rename current controller to v1
  • Mark current method as deprecated
  • Create v2 controller with new method

Additional information

After completion of this, a migration task should be added for clients to tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant