From a60f9186892a3e5a68b2569a944f92308139cf7d Mon Sep 17 00:00:00 2001 From: manishsaraan Date: Fri, 2 Mar 2018 17:02:12 +0530 Subject: [PATCH 1/2] Illegal constructor error fix --- dist/ngclipboard.js | 17 +++++++++-------- dist/ngclipboard.min.js | 6 +++--- src/ngclipboard.js | 13 +++++++------ 3 files changed, 19 insertions(+), 17 deletions(-) diff --git a/dist/ngclipboard.js b/dist/ngclipboard.js index 9d6ee55..54b4c5c 100644 --- a/dist/ngclipboard.js +++ b/dist/ngclipboard.js @@ -1,19 +1,19 @@ -/*! ngclipboard - v1.1.3 - 2017-10-31 +/*! ngclipboard - v1.1.3 - 2018-03-02 * https://github.com/sachinchoolur/ngclipboard -* Copyright (c) 2017 Sachin; Licensed MIT */ +* Copyright (c) 2018 Sachin; Licensed MIT */ (function() { 'use strict'; var MODULE_NAME = 'ngclipboard'; - var angular, Clipboard; - + var angular, ClipboardJS; + // Check for CommonJS support if (typeof module === 'object' && module.exports) { angular = require('angular'); - Clipboard = require('clipboard'); + ClipboardJS = require('clipboard'); module.exports = MODULE_NAME; } else { angular = window.angular; - Clipboard = window.Clipboard; + ClipboardJS = window.ClipboardJS; } angular.module(MODULE_NAME, []).directive('ngclipboard', function() { @@ -24,7 +24,8 @@ ngclipboardError: '&' }, link: function(scope, element) { - var clipboard = new Clipboard(element[0]); + //constructor for clipboardjs changed to ClipboardJS + var clipboard = new ClipboardJS(element[0]); clipboard.on('success', function(e) { scope.$apply(function () { @@ -41,7 +42,7 @@ }); }); }); - + element.on('$destroy', function() { clipboard.destroy(); }); diff --git a/dist/ngclipboard.min.js b/dist/ngclipboard.min.js index 5d3df5b..10adb12 100644 --- a/dist/ngclipboard.min.js +++ b/dist/ngclipboard.min.js @@ -1,4 +1,4 @@ -/*! ngclipboard - v1.1.3 - 2017-10-31 +/*! ngclipboard - v1.1.3 - 2018-03-02 * https://github.com/sachinchoolur/ngclipboard -* Copyright (c) 2017 Sachin; Licensed MIT */ -!function(){"use strict";var a,b,c="ngclipboard";"object"==typeof module&&module.exports?(a=require("angular"),b=require("clipboard"),module.exports=c):(a=window.angular,b=window.Clipboard),a.module(c,[]).directive("ngclipboard",function(){return{restrict:"A",scope:{ngclipboardSuccess:"&",ngclipboardError:"&"},link:function(a,c){var d=new b(c[0]);d.on("success",function(b){a.$apply(function(){a.ngclipboardSuccess({e:b})})}),d.on("error",function(b){a.$apply(function(){a.ngclipboardError({e:b})})}),c.on("$destroy",function(){d.destroy()})}}})}(); \ No newline at end of file +* Copyright (c) 2018 Sachin; Licensed MIT */ +!function(){"use strict";var a,b,c="ngclipboard";"object"==typeof module&&module.exports?(a=require("angular"),b=require("clipboard"),module.exports=c):(a=window.angular,b=window.ClipboardJS),a.module(c,[]).directive("ngclipboard",function(){return{restrict:"A",scope:{ngclipboardSuccess:"&",ngclipboardError:"&"},link:function(a,c){var d=new b(c[0]);d.on("success",function(b){a.$apply(function(){a.ngclipboardSuccess({e:b})})}),d.on("error",function(b){a.$apply(function(){a.ngclipboardError({e:b})})}),c.on("$destroy",function(){d.destroy()})}}})}(); \ No newline at end of file diff --git a/src/ngclipboard.js b/src/ngclipboard.js index 98bc4a1..6fd3181 100644 --- a/src/ngclipboard.js +++ b/src/ngclipboard.js @@ -1,16 +1,16 @@ (function() { 'use strict'; var MODULE_NAME = 'ngclipboard'; - var angular, Clipboard; - + var angular, ClipboardJS; + // Check for CommonJS support if (typeof module === 'object' && module.exports) { angular = require('angular'); - Clipboard = require('clipboard'); + ClipboardJS = require('clipboard'); module.exports = MODULE_NAME; } else { angular = window.angular; - Clipboard = window.Clipboard; + ClipboardJS = window.ClipboardJS; } angular.module(MODULE_NAME, []).directive('ngclipboard', function() { @@ -21,7 +21,8 @@ ngclipboardError: '&' }, link: function(scope, element) { - var clipboard = new Clipboard(element[0]); + //constructor for clipboardjs changed to ClipboardJS + var clipboard = new ClipboardJS(element[0]); clipboard.on('success', function(e) { scope.$apply(function () { @@ -38,7 +39,7 @@ }); }); }); - + element.on('$destroy', function() { clipboard.destroy(); }); From f2ad9fe695a9f7ca9d246296e585c6a2da252fc5 Mon Sep 17 00:00:00 2001 From: Sachin Date: Sat, 3 Mar 2018 12:10:44 +0530 Subject: [PATCH 2/2] Release 2.0 --- bower.json | 6 +++--- dist/ngclipboard.js | 2 +- dist/ngclipboard.min.js | 2 +- package.json | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/bower.json b/bower.json index 14d0273..cd835f8 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "ngclipboard", - "version": "1.1.3", + "version": "2.0.0", "homepage": "https://github.com/sachinchoolur/ngclipboard", "license": "MIT", "authors": [ @@ -16,8 +16,8 @@ "angularjs" ], "dependencies": { - "clipboard": "~1.5.5", - "angular": ">=1.2.0" + "clipboard": "^2.0.0", + "angular": "^1.2.0" }, "ignore": [ "README.md", diff --git a/dist/ngclipboard.js b/dist/ngclipboard.js index 54b4c5c..894dc42 100644 --- a/dist/ngclipboard.js +++ b/dist/ngclipboard.js @@ -1,4 +1,4 @@ -/*! ngclipboard - v1.1.3 - 2018-03-02 +/*! ngclipboard - v2.0.0 - 2018-03-03 * https://github.com/sachinchoolur/ngclipboard * Copyright (c) 2018 Sachin; Licensed MIT */ (function() { diff --git a/dist/ngclipboard.min.js b/dist/ngclipboard.min.js index 10adb12..e8dbf4d 100644 --- a/dist/ngclipboard.min.js +++ b/dist/ngclipboard.min.js @@ -1,4 +1,4 @@ -/*! ngclipboard - v1.1.3 - 2018-03-02 +/*! ngclipboard - v2.0.0 - 2018-03-03 * https://github.com/sachinchoolur/ngclipboard * Copyright (c) 2018 Sachin; Licensed MIT */ !function(){"use strict";var a,b,c="ngclipboard";"object"==typeof module&&module.exports?(a=require("angular"),b=require("clipboard"),module.exports=c):(a=window.angular,b=window.ClipboardJS),a.module(c,[]).directive("ngclipboard",function(){return{restrict:"A",scope:{ngclipboardSuccess:"&",ngclipboardError:"&"},link:function(a,c){var d=new b(c[0]);d.on("success",function(b){a.$apply(function(){a.ngclipboardSuccess({e:b})})}),d.on("error",function(b){a.$apply(function(){a.ngclipboardError({e:b})})}),c.on("$destroy",function(){d.destroy()})}}})}(); \ No newline at end of file diff --git a/package.json b/package.json index ac02c7b..95082f0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ngclipboard", - "version": "1.1.3", + "version": "2.0.0", "description": "Angularjs directive for clipboard.js", "keywords": [ "ngclipboard", @@ -29,13 +29,13 @@ "test": "grunt" }, "dependencies": { - "clipboard": "~1.5.5" + "clipboard": "^2.0.0" }, "peerDependencies": { - "angular": ">=1.2.0" + "angular": "^1.2.0" }, "devDependencies": { - "angular": ">=1.2.0", + "angular": "^1.2.0", "grunt": "^0.4.5", "grunt-contrib-clean": "^0.6.0", "grunt-contrib-concat": "^0.5.0",