Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New subgraph series to supersede the outdated names #57

Closed
3 tasks
PaulRBerg opened this issue Dec 21, 2024 · 6 comments
Closed
3 tasks

New subgraph series to supersede the outdated names #57

PaulRBerg opened this issue Dec 21, 2024 · 6 comments
Assignees
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Dec 21, 2024

As discussed in #53

The task is to create new subgraph series, as it is not possible to rename subgraphs on The Graph. The existing subgraphs will continue working.

  • New series for Flow to remove v2
  • New series for Lockup to remove v2
  • New series for the Airdrop contracts to remove v2 and ms (acronym for Merkle Streamer)

It'd be great if we could do this before/ during the Lockup v2.0.0 launch in Q1 2025 — I imagine that @gavriliumircea will have to go through the slog of updating all subgraphs anyway.

P.S. we should also create a PR in DeFiLlama to update the endpoints. edit: this is done now

@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Dec 21, 2024
@PaulRBerg
Copy link
Member Author

@razgraf @gavriliumircea will you be able to include this task before the release next week?

The longer we let it like this, the bigger the refactor it will be in the future. And the v2 name in the subgraph will confuse developers/integrators.

I think now it's a great time given that it was a major release.

@gavriliumircea
Copy link
Contributor

gavriliumircea commented Jan 29, 2025

Just so we are clear should we maintain the previous versions and the new ones? Also for Lockups if we simply remove the V2 we will have naming conflicts with some of the V1 subgraphs

@razgraf
Copy link
Member

razgraf commented Jan 29, 2025

Tasks:

  • Update sablier-v2 series to sablier-lockup-<network>
  • Update sablier-v2-ms series to sablier-airdrops-<network>
  • Update sablier-v2-fl series to sablier-flow-<network>
  • Update app endpoints
  • Update services endpoints
  • Update sandbox endpoints
  • Update docs with new endpoints (old ones should remain in the website under a "previous endpoints" page (a bit hidden) with a note somewhere in the new endpoints page about deprecating these old ones which will not include the latest versions
  • Update Snapshot with the new endpoints and networks
  • Update Zapper with the new endpoints and networks

Unsure where else these are being used...

@PaulRBerg
Copy link
Member Author

Just so we are clear should we maintain the previous versions and the new ones?

Yes, to not cause any downtime. But the previous versions should not receive any further updates (ever).

Also for Lockups if we simply remove the V2 we will have naming conflicts with some of the V1 subgraphs

Why? We can name them like so: sablier-lockup.

@PaulRBerg
Copy link
Member Author

@razgraf you can update the OP to add the todo list

@razgraf razgraf closed this as completed Feb 1, 2025
@PaulRBerg
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

No branches or pull requests

3 participants