Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Murky as dev dependency #10

Closed
PaulRBerg opened this issue Nov 21, 2024 · 3 comments · Fixed by #19
Closed

Add Murky as dev dependency #10

PaulRBerg opened this issue Nov 21, 2024 · 3 comments · Fixed by #19
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

To avoid having to maintain the code + benefit from the latest updates in Murky.

#5 (comment)

@PaulRBerg PaulRBerg added effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Nov 21, 2024
@andreivladbrg
Copy link
Member

I was trying to do this, but I’m afraid we can’t achieve it using bun, as the repo does not have a package.json file (https://app.warp.dev/block/pTzN20g0PhTxXTb9GGRFQn). Also, there’s an issue that has been open for 3 months now (dmfxyz/murky#20) with no response from the maintainer.

However, it worked using yarn: https://app.warp.dev/block/IibDd7etEkOYmYtVHVeu66.

So, should we wait until a package.json file is added to the repo, or should we discard this change?

@PaulRBerg
Copy link
Member Author

Will disregard for now. Thanks for trying to add it as a dependency.

Please add a comment in their repo to ask them to add a package.json file.

@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@PaulRBerg
Copy link
Member Author

Reopening as they added package.json

dmfxyz/murky#23 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants