-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: SubComponents (some?/all?) shown on a Component's doc page don't appear in search #259
Comments
BTW, many thanks for this product. There's a lot of work and love shown in here. If I can be productive in supporting, and if you could direct me how to contribute a solution for this, I'd be happy to pitch in some sweat equity. However, I'm sure you'd have strong thoughts on right way to go about this, especially if it meant creating new component names and aliasing to old ones, etc. |
This is great feedback, really appreciate it, it’s a massive help. i agree with all your points, and they will be addressed in v3. It’s been a huge undertaking to get everything to the level you (and i) are expecting, so i can use all help i can get. Now is a great time to help tinker about api and docs improvements as we’re preparing for v3. How about i create a shared document and outline all changes for v3, on which you can give feedback and proposals? |
A roadmap. Great way to rally contributors. |
Here's a rough start: https://dynamic-link-427.notion.site/Saas-UI-v3-10b7bf58b71a8033be0bdb3e6989759a I can also invite you to the notion page so you can comment on there directly. |
That'd be great. Some early suggestions until I can comment, which I recognize reflect some personal pain-points and may not be aligned to your long-term investment in the project:
Stuff that I know gets into opinion-land, about using more standard tech for a library:
|
Can you share you email address for notion? you can mail it to [email protected]
I assume you mean alias everything uses tsconfig path aliases?
Assuming you mean the Add more basic As well as a new CLI that can install components / blocks / templates into existing projects (including installing required dependencies, etc)
I'm not a big fan of too much linting rules, so I kept it fairly simple. But I do agree we could settle on a popular config that works well across typescript frameworks. I think the Epic web configs are good too: https://github.com/epicweb-dev/config
Great idea, although I lack development bandwidth for this myself and need all the time I have to start the v3 migration.
Unfortunately I find npm very lacking in some features and not very suitable for managing a repo for library of packages. A lot of projects have switched to PNPM.
Yes I rather make this happen with the CLI that can eject examples into stand alone projects that could use NPM by default.
Not sure if this is a valid argument, since Yarn is embedded in the repository and doesn't require any installation.
Absolutely, I already started experimenting with Vite and Tanstack Router, I'm finding Next.js becoming too complex and slow as well.
Agreed.
Agreed.
It's definitely possible, but with the move to a more SSR based framework it is becoming cumbersome.
Next.js actually kinda locks you in to Vercel if you want to have best support for features like edge routes, etc. |
Ah! Sorry, I used a generic but incorrect term. I meant using That's slightly more work for contributors, but good general hygiene, and it makes the sample app a usable template for users without any manual port-ins from the monorepo. If you're already planning to move it to a separate repo, then you'll end up in the same place anyway! But it could be a nice bridging step as you gradually decouple... |
Tell me more, please! I've found the npm |
That's a super-cool idea. My suggestions were focused on the baseline assumption you didn't want to add any new kinds of magic/tooling. But if you're going down that road, I completely agree that the package-manager shouldn't matter much. |
Description
When I search for "NavItem" or "NavGroup" in the SaasUI docs site, I expect to find it in the results. Instead, I have to infer from the sample app that, since the NavItem is used within the Sidebar, I should go look there for its docs, even though its component name wouldn't imply that's the place to look.
Related: I'd expect the structure of Storybook to similarly make it clear how to find docs on such a component. Instead, the 'NavItem' and 'NavGroup' are under a heading called 'Navigation' which has a heading in the docs... but these components aren't there.
Link to Reproduction
https://saas-ui.dev/docs/components/layout/sidebar
Steps to reproduce
Saas UI Version
2.8.7
Chakra UI Version
2.8.2
Browser
All
Operating System
Additional Information
If nothing else, it would help to change the name of all sub-components so that they're at least namespaced to the parent component where I can find the docs. For instance:
Sidebar-NavItem
instead ofNavItem
tells me where to look for docs. That would at least solve 80% of the problem, if there's a logical way to do that, and if some of the problem components don't belong to multiple parents. (But... that's a workaround. They should still show up in search.)(P.S. I'm a paid user of SaasUI-pro for a prototype. I love where it's headed in many ways, but spending 10 minutes scratching my head looking for docs on a basic component makes me loath to scale it across my company. I know you might be focused on other key features, but for an enterprise product, complete docs are a key feature.)
The text was updated successfully, but these errors were encountered: