Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: toggle should have a hover state #2741

Closed
amir20 opened this issue Jan 8, 2024 · 4 comments
Closed

bug: toggle should have a hover state #2741

amir20 opened this issue Jan 8, 2024 · 4 comments

Comments

@amir20
Copy link

amir20 commented Jan 8, 2024

What version of daisyUI are you using?

daisyui 4.5.0

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

n/a

Describe your issue

By default, DaisyUI's button has hover

@media (hover: hover) {
&:hover {
@apply border-base-300 bg-base-300;
@supports (color: color-mix(in oklab, black, black)) {
background-color: color-mix(
in oklab,
oklch(var(--btn-color, var(--b2)) / var(--tw-bg-opacity, 1)) 90%,
black
);
border-color: color-mix(
in oklab,
oklch(var(--btn-color, var(--b2)) / var(--tw-border-opacity, 1)) 90%,
black
);
}
@supports not (color: oklch(0 0 0)) {
background-color: var(--btn-color, var(--fallback-b2));
border-color: var(--btn-color, var(--fallback-b2));
}
}
}

However, I noticed the same doesn't exist for toggle.

Is this done intentionally?

Copy link

github-actions bot commented Jan 8, 2024

Thank you @amir20 for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@amir20
Copy link
Author

amir20 commented Jan 8, 2024

PS. thanks for the amazing library

@amir20
Copy link
Author

amir20 commented Jan 8, 2024

Happy to send a PR if it should have hover state.

@saadeghi
Copy link
Owner

I don't think it's necessary, but of course you can customize the style for your own project using utility classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants