Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual: Send emails in the correct language #698

Open
stephanbrunker opened this issue Apr 21, 2020 · 0 comments
Open

Multilingual: Send emails in the correct language #698

stephanbrunker opened this issue Apr 21, 2020 · 0 comments
Assignees

Comments

@stephanbrunker
Copy link
Contributor

If a new comment is processed, several mails are sent by the core. Unfortunately, these mails are sent in the language serendipity runs at the time, so if a commenter gets the site displayed in a different than default language, the author gets the notification also in that language.

Because the changes in #692 include also a lot of email sending, there is an universal fix which means to load the language strings for emailing not into constants but into variables. Unfortunately, that means to identify and pull out the mail language strings out of all the lang files and put them into a new type of lang file with variables so the function can load the right language based on the settings of the recipient.

I am going to fix that after I get the subscription itself running which can only take a few more dozen hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant