Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise core language files #630

Open
1 of 3 tasks
th-h opened this issue Aug 17, 2019 · 1 comment
Open
1 of 3 tasks

Synchronise core language files #630

th-h opened this issue Aug 17, 2019 · 1 comment
Assignees
Milestone

Comments

@th-h
Copy link
Member

th-h commented Aug 17, 2019

The language files in core are a bit out of sync - different order, duplicate definitions, some new constants not added to every language, some old ones not deleted everywhere.

  • Add a check script to find and report those deviations
  • Remove duplicates in all language files
  • Add missing constants and remove those that are no longer present in EN (and no longer used in code)
@th-h th-h added this to the 2.4 milestone Aug 17, 2019
@th-h th-h self-assigned this Aug 17, 2019
@stephanbrunker
Copy link
Contributor

I have done this, because I added a few additional definitions for my new feature branch. I have sorted the english file according to the file/module where the strings are used, put all these where I couldn't find a usage into a separate "orphaned" section and then wrote an langsorter.php script which ordered all the files according to the english one.

Already included in the feature_subscription branch, but you can cherry-pick the commits c773b5f and fb928af which handle the language files.

Remaining Todo is then to check the orphaned constants - I found 73 from line 1203 to 1279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants