Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't acknowledge any message from the stream until it restarts #37

Closed
vrongmeal opened this issue Jan 27, 2025 · 1 comment
Closed

Don't acknowledge any message from the stream until it restarts #37

vrongmeal opened this issue Jan 27, 2025 · 1 comment
Labels
area:bento Tickets related to the bento plugin bug Something isn't working

Comments

@vrongmeal
Copy link
Member

vrongmeal commented Jan 27, 2025 •
edited
Loading

The AckFunc should reset cache to last sequence number that was successfully acknowledged on error instead of setting the sequence number pessimistically.

s2-sdk-go/s2-bentobox/input.go

Lines 319 to 320 in 9bf21a0

// Close a specific worker and let it restart.
i.closeWorker <- stream

@vrongmeal vrongmeal added area:bento Tickets related to the bento plugin bug Something isn't working labels Jan 27, 2025
@vrongmeal
Copy link
Member Author

This is resolved - the implementation was changed completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:bento Tickets related to the bento plugin bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vrongmeal