Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build an interface for network creation #10

Open
s-sd opened this issue Jul 13, 2023 · 3 comments
Open

Build an interface for network creation #10

s-sd opened this issue Jul 13, 2023 · 3 comments
Assignees

Comments

@s-sd
Copy link
Owner

s-sd commented Jul 13, 2023

options include: conv or fully connected
should take: input shape and output shape and continuous/ discrete/ multi-discrete
should output a constructed network

@i-gayo
Copy link
Collaborator

i-gayo commented Jul 16, 2023

Will build on this! @i-gayo @s-sd

@i-gayo i-gayo self-assigned this Jul 16, 2023
@s-sd
Copy link
Owner Author

s-sd commented Jul 16, 2023

That's great! Thanks @i-gayo ! Let me know if any help needed. You can directly create a branch called something like issue-10 and create a PR when you're ready to merge it to main. :)

A few additional related things:

  • Best to put this in utils as a function that can be called.
  • The simpler and more readable the implementation, the better.
  • For multi-discrete networks, we want a branched network, each outputting the num_actions specified in multi-discrete e.g., if the user defines the actions space as MultiDiscrete([[2, 3], [2,4]]), we want 4 network branches, each with the number of nodes specified.
  • Also MultiDiscrete should simplify to MultiBinary for cases where num-actions=2.

MultiDiscrete is a complicated case so you can even leave that for later, since I have not yet implemented REINFORCE for it yet. Let me know if any thoughts or ideas.

@i-gayo
Copy link
Collaborator

i-gayo commented Jul 20, 2023

Implemented this function for discrete and continuous action spaces, but will still need to do a few things:

  1. Implement for multi-discrete cases
  2. Finalise input types / shapes for function
  3. Check compatibility with demos, to check for bugs in code
  4. (Optional) write tests

i-gayo added a commit that referenced this issue Aug 11, 2023
i-gayo added a commit that referenced this issue Aug 14, 2023
i-gayo added a commit that referenced this issue Aug 17, 2023
s-sd added a commit that referenced this issue Aug 18, 2023
s-sd added a commit that referenced this issue Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants