Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsize first FITS file more on EXOTIC Colab in Step 3 #1247

Open
rzellem opened this issue Mar 26, 2024 · 5 comments
Open

Downsize first FITS file more on EXOTIC Colab in Step 3 #1247

rzellem opened this issue Mar 26, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@rzellem
Copy link
Owner

rzellem commented Mar 26, 2024

Some large files (see attached) do not load in Step 3 (where you ID your target and comp stars) - so we need to downsample the first image more to ensure that it loads and does not time out the Colab
Uploading 2024-01-29_20-02-35_UVIR_10.00_Gain100_Focus-24136_60.00s_1x1_0012_c_20240324212540.fits.zip…

@rzellem rzellem added the enhancement New feature or request label Mar 26, 2024
@ivenzor
Copy link
Contributor

ivenzor commented Nov 25, 2024

@tamimfatahi @rzellem, I’ve worked a bit on this issue. Before creating a PR, could you take a look and let me know if this aligns with what you have in mind? I’m attaching an image (I tried to attach the HTML file, but it’s not supported).

New Features:

  1. Downsampling the image to 1MB to balance speed and resolution if the input image exceeds 1MB.
  2. When hovering, the original coordinates are shown instead of the downsampled ones.
  3. Added controls to flip the image horizontally and vertically while retaining the original coordinates.
  4. Added controls to adjust how the image is displayed (low percentile and high percentile settings).

I could also add RA and DEC coordinates when hovering, provided the image is plate solved.

Captura de pantalla 2024-11-25 115502

@rzellem
Copy link
Owner Author

rzellem commented Nov 25, 2024

@ivenzor - these changes look awesome!

Can you talk more about the downsampling? How does it do that? Does it bin the pixel size? Or something else?

If it bins the pixel size, I'd be a little worried that it could "bin away" some of the smaller/dimmer stars.

@ivenzor
Copy link
Contributor

ivenzor commented Nov 26, 2024

@rzellem currently I'm using the skimage.transform.resize function. It's a spline interpolation, Bi-linear by default:

0: Nearest-neighbor
1: Bi-linear (default)
2: Bi-quadratic
3: Bi-cubic
4: Bi-quartic
5: Bi-quintic
Default is 0 if image.dtype is bool and 1 otherwise.

@rzellem
Copy link
Owner Author

rzellem commented Nov 26, 2024

Very cool! I didn't know about this feature- this is super helpful! I wonder if we should also build this into the Image Inspector as well?

@ivenzor
Copy link
Contributor

ivenzor commented Nov 26, 2024

I’ll work on a PR for the 'locating target star' step, and if everything goes well, I’ll also take a look at the notebook code for inspecting the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants