Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #2

Open
fernbacher opened this issue Apr 11, 2023 · 4 comments
Open

Windows compatibility #2

fernbacher opened this issue Apr 11, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@fernbacher
Copy link

Would love it for windows aswell if you could do it. The other options for windows are buggy, not updated, not working and dont have cover art.

@ryze312
Copy link
Owner

ryze312 commented Apr 11, 2023

Sure, I've been thinning of making a separate branch for Windows. As it is currently implemented that's not easy to do, since plugin is compiled as a C plugin for mpv, which is only supported on Linux.

The best way to do this is to abstract mpv event observing and requests (OSD for example) and implement them separately for Linux as a C plugin and Windows as a subprocess of Lua script, which would be a middle man in communicating.

@ryze312
Copy link
Owner

ryze312 commented Apr 11, 2023

If anyone else needs Windows support, react or comment. The more people want this feature, the sooner I will work on it.

@ryze312 ryze312 added the enhancement New feature or request label Apr 11, 2023
@ryze312 ryze312 added this to the 2.0 milestone Apr 11, 2023
@WhoMI7
Copy link

WhoMI7 commented Jun 25, 2023

Commenting so I get notified when windows is compatible.

@AKL55
Copy link

AKL55 commented Dec 12, 2023

This is the best script by far!
I hope to be able to use on windows aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants