From f6f7d27b87423bced94426041e36c8a194207c25 Mon Sep 17 00:00:00 2001
From: starkillerOG <starkiller.og@gmail.com>
Date: Wed, 9 Nov 2022 20:29:05 +0100
Subject: [PATCH 1/2] Update devicestatus.py

---
 miio/devicestatus.py | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/miio/devicestatus.py b/miio/devicestatus.py
index d3fe0242f..55b9ec259 100644
--- a/miio/devicestatus.py
+++ b/miio/devicestatus.py
@@ -2,16 +2,7 @@
 import logging
 import warnings
 from enum import Enum
-from typing import (
-    Callable,
-    Dict,
-    Optional,
-    Type,
-    Union,
-    get_args,
-    get_origin,
-    get_type_hints,
-)
+from typing import Dict, Optional, Type, Union, get_args, get_origin, get_type_hints
 
 from .descriptors import (
     BooleanSettingDescriptor,
@@ -131,7 +122,7 @@ def __getattr__(self, item):
         return getattr(self._embedded[embed], prop)
 
 
-def sensor(name: str, *, unit: str = "", **kwargs):
+def sensor(name: str, *, unit: Optional[str] = None, **kwargs):
     """Syntactic sugar to create SensorDescriptor objects.
 
     The information can be used by users of the library to programmatically find out what
@@ -143,7 +134,8 @@ def sensor(name: str, *, unit: str = "", **kwargs):
     """
 
     def decorator_sensor(func):
-        property_name = func.__name__
+        property_name = str(func.__name__)
+        qualified_name = str(func.__qualname__)
 
         def _sensor_type_for_return_type(func):
             rtype = get_type_hints(func).get("return")
@@ -157,8 +149,8 @@ def _sensor_type_for_return_type(func):
 
         sensor_type = _sensor_type_for_return_type(func)
         descriptor = SensorDescriptor(
-            id=str(property_name),
-            property=str(property_name),
+            id=qualified_name,
+            property=property_name,
             name=name,
             unit=unit,
             type=sensor_type,
@@ -174,7 +166,6 @@ def _sensor_type_for_return_type(func):
 def setting(
     name: str,
     *,
-    setter: Optional[Callable] = None,
     setter_name: Optional[str] = None,
     unit: Optional[str] = None,
     min_value: Optional[int] = None,
@@ -196,14 +187,15 @@ def setting(
     """
 
     def decorator_setting(func):
-        property_name = func.__name__
+        property_name = str(func.__name__)
+        qualified_name = str(func.__qualname__)
 
-        if setter is None and setter_name is None:
-            raise Exception("Either setter or setter_name needs to be defined")
+        if setter_name is None:
+            raise Exception("Setter_name needs to be defined")
 
         common_values = {
-            "id": str(property_name),
-            "property": str(property_name),
+            "id": qualified_name,
+            "property": property_name,
             "name": name,
             "unit": unit,
             "setter": setter,

From ba2f64bff170fedc3877e74e37a65a49f297ae6a Mon Sep 17 00:00:00 2001
From: starkillerOG <starkiller.og@gmail.com>
Date: Wed, 9 Nov 2022 20:52:14 +0100
Subject: [PATCH 2/2] fix

---
 miio/devicestatus.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/miio/devicestatus.py b/miio/devicestatus.py
index 55b9ec259..e05f113c0 100644
--- a/miio/devicestatus.py
+++ b/miio/devicestatus.py
@@ -198,7 +198,6 @@ def decorator_setting(func):
             "property": property_name,
             "name": name,
             "unit": unit,
-            "setter": setter,
             "setter_name": setter_name,
             "extras": kwargs,
         }