-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstable fingerprints for item_children - ICE on Rust 1.52.0 stable #85019
Comments
@rustbot label: +regression-from-stable-to-stable |
Can confirm this doesn't happen on 1.51.0 stable |
I can't reproduce it on linux neither with |
Neither can I repro on our Linux/macOS/Windows (Intel x86) machines |
Our CI continues to reproduce this exact error in subsequent runs:
Oddly enough, it passes with: https://build.skytable.io/skytable/skytable/102/1/3 and fails right on the next ones. Since deps were upgraded, there were some changes to the target folder which I'm going to assume caused the build to pass. I'm making this assumption from the build log which shows 'fresh' for run 102, but doesn't on subsequent runs |
We continue to reproduce this error; I'm creating a new storage pool for the CI runs to see if it helps; all relevant failure logs can be found here: https://build.skytable.io/skytable/skytable Edit: By new storage pool I mean we're technically removing all the earlier cache |
Please see #84970 - you should likely be able to fix with CARGO_INCREMENTAL=0 for the time being. |
This is fixed on the latest nightly |
We're going to remove the I-prioritize label, we think this (and related) issue are already being handled (Zulip thread) in the context of the general parent issue. @rustbot label -I-prioritize |
Removing the regression label since this occurred on earlier releases, it just didn't ICE (see #84970 for context). |
I am getting an
Backtrace
|
This might be the issue for me as well since this is occurring after moving a cached target directory (for CI purposes), although I have not tested whether this is the cause. |
@Imberflur: Does this happen on CI, or are you able to consistently reproduce this locally? I suspect that this will be fixed by #85153, since the global untracked state |
@Aaron1011 I'm not able to reproduce this locally |
Update: Even after upgrading to 1.54 and clearing out older caches completely, we're seeing a number of ICEs:
Edit 1: Unless the cache is deleted after every run, we'd get an ICE |
@ohsayan: Have you been able to reproduce the ICE on linux? |
@Aaron1011 All our CI runners on Linux use caching, but none of them have shown any ICEs yet. |
This issue isn't platform-specific after all. It occurs when the crate is rebuilt with the same target directory (set with |
Include (potentially remapped) working dir in crate hash Fixes rust-lang#85019 A `SourceFile` created during compilation may have a relative path (e.g. if rustc itself is invoked with a relative path). When we write out crate metadata, we convert all relative paths to absolute paths using the current working directory. However, the working directory is not included in the crate hash. This means that the crate metadata can change while the crate hash remains the same. Among other problems, this can cause a fingerprint mismatch ICE, since incremental compilation uses the crate metadata hash to determine if a foreign query is green. This commit moves the field holding the working directory from `Session` to `Options`, including it as part of the crate hash. cc `@ohsayan`
Code
Skytable is quite a large project and I'm trying to produce a MCVE as soon as I can.
You can find the relevant logs on our CI server: https://build.skytable.io/skytable/skytable/98/1/3. From what I can see, this only happens on 1.52.0 and I'm supposing this is a regression from stable. For what it's worth, our CI server is running on an M1 Chip (aarch64-apple-darwin). From the backtrace it seems like the compiler panics while trying to build the sky-bench component or libsky (which is the smallest part of the project)
Update [August-08-2021]: After upgrading to 1.54, ICEs continue to appear. See this comment
Update [August-09-2021] @Aaron1011 has investigated this extensively. Please refer to this comment and see the log here
Runs
(can repro on every re-run)
Meta
rustc --version --verbose
:Backtrace
Related issues: #85003, #83291, #84970 (kept open as this is aarch64-apple-darwin)
The text was updated successfully, but these errors were encountered: