Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use full strip cli args in cg_ssa #135038

Open
jieyouxu opened this issue Jan 2, 2025 · 1 comment
Open

cleanup: use full strip cli args in cg_ssa #135038

jieyouxu opened this issue Jan 2, 2025 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jan 2, 2025

Suggestion [DISCARD-ALL 1/2]: can we spell out the full flag for this as well? llvm-objcopy docs say that -x is

--discard-all, -x

Remove most local symbols from the output. Different file formats may limit this to a subset of the local symbols. For example, file and section symbols in ELF objects will not be discarded. Additionally, remove all debug sections.

This happens to align with llvm-strip, unlike -S or no-flag.

Originally posted by @jieyouxu in #135034 (comment)

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 2, 2025
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 2, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 2, 2025

Note: this depends on what the concrete strip-like command cli scheme is for a given platform in cg_ssa/back/link.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants