run-make-support: assert_dirs_are_equal traverses symlinks
#135037
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
jieyouxu
added
A-run-make
rustbot
added
the
needs-triage
jieyouxu
removed
the
needs-triage
github-project-automation
bot
moved this to Backlog
in compiletest maintenance and improvements
|
It makes sense to me not to traverse symlinks by default. But some people aren't me. In any case, either behaviour can be reasonable depending on the test so I'd vote for making it configurable. |
|
Note: this should also have some basic sanity self-test coverage. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 3, 2025
…r-errors run-make-support: adjust assertion printing, add some basic sanity checks cc `@Noratrieb` I think we may have unintentionally regressed this recently and double-printed (or printed even when the assertions didn't fail). This PR should condition the detail dumps only when the assertions fail. Added some basic sanity checks for the assertions helpers except for the directory comparisons. That particular helper is not robust against symlinks, and I intend to address it in a follow-up (issue is rust-lang#135037). r? bootstrap (or compiler)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 3, 2025
…r-errors run-make-support: adjust assertion printing, add some basic sanity checks cc ``@Noratrieb`` I think we may have unintentionally regressed this recently and double-printed (or printed even when the assertions didn't fail). This PR should condition the detail dumps only when the assertions fail. Added some basic sanity checks for the assertions helpers except for the directory comparisons. That particular helper is not robust against symlinks, and I intend to address it in a follow-up (issue is rust-lang#135037). r? bootstrap (or compiler)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 4, 2025
Rollup merge of rust-lang#135036 - jieyouxu:rmake-be-quiet, r=compiler-errors run-make-support: adjust assertion printing, add some basic sanity checks cc ``@Noratrieb`` I think we may have unintentionally regressed this recently and double-printed (or printed even when the assertions didn't fail). This PR should condition the detail dumps only when the assertions fail. Added some basic sanity checks for the assertions helpers except for the directory comparisons. That particular helper is not robust against symlinks, and I intend to address it in a follow-up (issue is rust-lang#135037). r? bootstrap (or compiler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
assert_dirs_are_equalwill try to read the file content behind symlinks, which is not necessarily the desired behavior. Either we should make it configurable, or avoid traversing symlinks.The text was updated successfully, but these errors were encountered: